Fix bug where we send an extra newline character at the end of a multipa... by JonathanSmith · Pull Request #29 · googleapis/google-cloud-node

JonathanSmith · 2014-07-23T18:14:42Z

As per.

http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html

There is only one newline/CRLF required before the final --boundary--, the second newline will be interpreted as data and appended to the payload.

I'm not sure if this is a platform specific issue as I have not tested this on windows. Perhaps it changes and should be a specific hex string for the newline delimiters?

…ipart upload.

JonathanSmith · 2014-07-23T18:15:31Z

Associated issue here:
#28

rakyll · 2014-07-23T19:14:26Z

Looks good.

Jonathan, did you sign Google's CLA? It's been explained on Contributing section (https://github.com/GoogleCloudPlatform/gcloud-node#contributing).

I can merge it once you sign it. Thanks.

rakyll · 2014-07-25T18:08:51Z

Any news?

This bug is blocking our next release, I will need to contribute it myself :(

JonathanSmith · 2014-07-25T18:26:43Z

Hi,
Sorry,

I've been working on getting the Corporate CLA signed by my company. I just poked our signature guy again so I'll let you know when it is signed/submitted, I hope they can get it back to me today. (If not, please don't let it block your release, as it is a very small change).

rakyll · 2014-07-25T19:13:30Z

Yes, corporate CLAs might be an overkill for small changes. Let's wait until Monday. If we are not able to merge this, I'll author it.

rakyll · 2014-07-29T00:06:36Z

Sent this change as 82544bb

🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.5](https://www.github.com/googleapis/nodejs-vpc-access/compare/v1.0.4...v1.0.5) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#29](https://www.github.com/googleapis/nodejs-vpc-access/issues/29)) ([670c82a](https://www.github.com/googleapis/nodejs-vpc-access/commit/670c82af3caf3adef7104dab62842ba46f110c85)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: lock files maintenance * chore: lock files maintenance

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* Introduce ESLint. Because ESLint does not support NodeJS 0.12.x, yet another script is added to skip "npm run lint". * Add eslintrc.yml

This is needed to fix the problem with the system tests on CircleCI where the file specified by GOOGLE_APPLICATION_CREDENTIALS could not be found.

* The output from proto file compilation is now checked into the repo. The proto compile step does not need to be run on each compile/test. Instead we can regenerate the output files whenever the proto is updated. For this to work, we needed to ensure that the relative path to the generated files remains the same between compile time and runtime – these files are needed at both times. * Reorganize the source code so that we no longer change the path relative to the root directory as part of the compilation process. * TypeScript wants all source files to be in the `rootDir` which necessitated the move of third_party/types. Hopefully we can get rid of this file completely soon. * Drop types/gcp-metadata-types.ts as gcp-metadata now ships with types. * Drop third_party from package.json/files. Not sure why it needed to shipped. * exclude build and proto directories from coverage

Coverage reporting regressed by #29 which added build/ to nyc.exclude configuration.

* The output from proto file compilation is now checked into the repo. The proto compile step does not need to be run on each compile/test. Instead we can regenerate the output files whenever the proto is updated. For this to work, we needed to ensure that the relative path to the generated files remains the same between compile time and runtime – these files are needed at both times. * Reorganize the source code so that we no longer change the path relative to the root directory as part of the compilation process. * TypeScript wants all source files to be in the `rootDir` which necessitated the move of third_party/types. Hopefully we can get rid of this file completely soon. * Drop types/gcp-metadata-types.ts as gcp-metadata now ships with types. * Drop third_party from package.json/files. Not sure why it needed to shipped. * exclude build and proto directories from coverage

Coverage reporting regressed by #29 which added build/ to nyc.exclude configuration.

* Fix samples, upgrade repo-tools, and regenerate scaffolding.

This is needed to fix the problem with the system tests on CircleCI where the file specified by GOOGLE_APPLICATION_CREDENTIALS could not be found.

Fix bug where we send an extra newline character at the end of a mult…

79ee8a7

…ipart upload.

rakyll added 0.0.x labels Jul 23, 2014

rakyll closed this Jul 29, 2014

rakyll mentioned this pull request Jul 29, 2014

Files uploaded on linux receive an extra newline byte at the end of the file. #28

Closed

chingor13 pushed a commit that referenced this pull request Aug 26, 2022

fix(deps): google-gax v2.24.1 (#29)

9a7471a

chingor13 pushed a commit that referenced this pull request Sep 13, 2022

fix(deps): google-gax v2.24.1 (#29)

df8b1df

sofisl pushed a commit that referenced this pull request Sep 15, 2022

test: throw on deprecation (#29)

1fb81fc

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 27, 2022

Fixes broken links in generated v1p1beta1 docs (#29)

a6e9754

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: lock files maintenance (#29)

26cf3b5

* chore: lock files maintenance * chore: lock files maintenance

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

docs: update link to client docs (#29)

3bea165

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore: release 2.1.0 (#29)

fde20ed

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-recommender #3409

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore: release 1.0.1 (#29)

71ca7a8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-bigquery-reservation #3413

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore: release 1.0.3 (#29)

b592f0f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This was referenced Oct 13, 2022

migrate code from googleapis/nodejs-cloud-shell #3415

Merged

migrate code from googleapis/nodejs-dataplex #3418

Merged

takeratta mentioned this pull request Nov 28, 2023

[Snyk] Fix for 8 vulnerabilities takeratta/google-cloud-node#23

Open

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025

Introduce ESLint. (#29)

e01b6c1

* Introduce ESLint. Because ESLint does not support NodeJS 0.12.x, yet another script is added to skip "npm run lint". * Add eslintrc.yml

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

chore: Specify the working_directory for sys tests (#29)

d1c575d

This is needed to fix the problem with the system tests on CircleCI where the file specified by GOOGLE_APPLICATION_CREDENTIALS could not be found.

GautamSharda pushed a commit that referenced this pull request Jan 15, 2026

chore: Specify the working_directory for sys tests (#29)

c545751

This is needed to fix the problem with the system tests on CircleCI where the file specified by GOOGLE_APPLICATION_CREDENTIALS could not be found.

GautamSharda mentioned this pull request Jan 20, 2026

chore: migrate code from googleapis/nodejs-error-reporting #7019

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Jan 27, 2026

fix: remove build/ from nyc exclude (#33)

6db4dc0

Coverage reporting regressed by #29 which added build/ to nyc.exclude configuration.

This was referenced Jan 27, 2026

migrate code from googleapis/cloud-profiler-nodejs #7043

Closed

migrate code from googleapis/cloud-profiler-nodejs #7044

Closed

migrate code from googleapis/cloud-profiler-nodejs #7045

Closed

migrate code from googleapis/cloud-profiler-nodejs #7046

Closed

sofisl pushed a commit that referenced this pull request Jan 27, 2026

fix: remove build/ from nyc exclude (#33)

b3a39d8

Coverage reporting regressed by #29 which added build/ to nyc.exclude configuration.

sofisl pushed a commit that referenced this pull request Feb 3, 2026

Fix samples, upgrade repo-tools, and regenerate scaffolding. (#29)

aa95e38

* Fix samples, upgrade repo-tools, and regenerate scaffolding.

sofisl mentioned this pull request Feb 3, 2026

migrate code from googleapis/nodejs-bigquery #7111

Merged

4 tasks

GautamSharda pushed a commit that referenced this pull request Feb 5, 2026

chore: Specify the working_directory for sys tests (#29)

9e13dad

This is needed to fix the problem with the system tests on CircleCI where the file specified by GOOGLE_APPLICATION_CREDENTIALS could not be found.

GautamSharda mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-error-reporting #7169

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug where we send an extra newline character at the end of a multipa...#29

Fix bug where we send an extra newline character at the end of a multipa...#29
JonathanSmith wants to merge 1 commit intogoogleapis:masterfrom
JonathanSmith:master

JonathanSmith commented Jul 23, 2014

Uh oh!

JonathanSmith commented Jul 23, 2014

Uh oh!

rakyll commented Jul 23, 2014

Uh oh!

rakyll commented Jul 25, 2014

Uh oh!

JonathanSmith commented Jul 25, 2014

Uh oh!

rakyll commented Jul 25, 2014

Uh oh!

rakyll commented Jul 29, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

JonathanSmith commented Jul 23, 2014

Uh oh!

JonathanSmith commented Jul 23, 2014

Uh oh!

rakyll commented Jul 23, 2014

Uh oh!

rakyll commented Jul 25, 2014

Uh oh!

JonathanSmith commented Jul 25, 2014

Uh oh!

rakyll commented Jul 25, 2014

Uh oh!

rakyll commented Jul 29, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants