DO NOT MERGE: BigQuery API stubs#262
Closed
ryanseys wants to merge 5 commits intogoogleapis:masterfrom
ryanseys:ryan-bigq
Closed
DO NOT MERGE: BigQuery API stubs#262ryanseys wants to merge 5 commits intogoogleapis:masterfrom ryanseys:ryan-bigq
ryanseys wants to merge 5 commits intogoogleapis:masterfrom
ryanseys:ryan-bigq
Conversation
Contributor
|
I took a quick look and, as always, it looks awesome to me! I'll dig deeper by early next week. I've started ordering methods by name, and putting any It makes it easier when coming to a file, knowing what you're looking for, but not sure where it is without doing a search -- also helps if the tests are sorted by the same order for the same reason. That's my only lame critique 🐦 |
Contributor
|
@ryanseys I'm carrying this on in https://github.com/stephenplusplus/gcloud-node/tree/spp--bigquery 👍 |
Contributor
Author
|
Cool. Shall we close this? |
Contributor
|
❌ 👍 |
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 15, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
* updated CHANGELOG.md * updated package.json * updated samples/package.json
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
* updated CHANGELOG.md * updated package.json * updated samples/package.json
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
#262) * build(node): add feat in node post-processor to add client library version number in snippet metadata Co-authored-by: Benjamin E. Coe <bencoe@google.com> Source-Link: googleapis/synthtool@d337b88 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
* updated CHANGELOG.md * updated package.json * updated samples/package.json
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md * updated package.json * updated samples/package.json
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
…ault (#262) * feat: hide samples with path containing @google-cloud/profiler by default * clarify comment
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
…ault (#262) * feat: hide samples with path containing @google-cloud/profiler by default * clarify comment
This was referenced Jan 27, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 29, 2026
This was referenced Jan 29, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 3, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I'd like to propose the stubs for BigQuery. In general, the API has been broken into four different pieces:
bigquery/index.js- The main BigQuery API. You create abigqueryobject much like we already have forstorage,datastoreandpubsub.bigquery/dataset.js- A Dataset holds Tables. You cannot have Tables without a Dataset, so this abstraction is necessary.bigquery/dataset.table.js- The table holds all the data. Using jobs, you insert data into the Table, run queries on data in Tables, and can even export data to Cloud Storage or copy data from one Table to another.bigquery/job.js- A job is some computation/data heavy task that is running on BigQuery. The results of jobs are stored in BigQuery and can only be accessed if you know the Job id. For the most part, jobs will be started through helper methods on Table and BigQuery itself, but this abstraction also gives developers flexibility.I haven't used this style of proposal before, but wanted to get a feel that I'm on the right track. Please let me know if you see any issues regarding general design, big missing details, something smells 🐟y, or you're amazed by something and want to send me 💰 or 🎁.
Any feedback is greatly appreciated. :)
PS: Don't merge this, that'd be silly as it only contains stubs. 🙈