logging-{winston,bunyan}: accept serviceContext#2585
Merged
stephenplusplus merged 3 commits intogoogleapis:masterfrom Sep 1, 2017
Merged
logging-{winston,bunyan}: accept serviceContext#2585stephenplusplus merged 3 commits intogoogleapis:masterfrom
stephenplusplus merged 3 commits intogoogleapis:masterfrom
Conversation
Accept serviceContext option at instantiation time. This is added to error logs to allow Stackdriver to pick-up errors and associate with the provided service. For full details see: https://cloud.google.com/error-reporting/docs/formatting-error-messages Fixes: googleapis#2513
googlebot
added
the
cla: yes
DominicKramer
approved these changes
Sep 1, 2017
packages/logging-bunyan/src/index.js
Outdated
| * as the service context. For more information see | ||
| * [this guide]{@link https://cloud.google.com/error-reporting/docs/formatting-error-messages} | ||
| * and the [official documentation]{@link https://cloud.google.com/error-reporting/reference/rest/v1beta1/ServiceContext}. | ||
| * @param {string} options.serviceContext.service |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Contributor
Author
|
Apologies. Fixed. |
Contributor
|
LG, thanks! |
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
* logging-{winston,bunyan}: accept serviceContext
Accept serviceContext option at instantiation time. This is added to
error logs to allow Stackdriver to pick-up errors and associate with
the provided service.
For full details see: https://cloud.google.com/error-reporting/docs/formatting-error-messages
Fixes: #2513
This was referenced Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
* logging-{winston,bunyan}: accept serviceContext
Accept serviceContext option at instantiation time. This is added to
error logs to allow Stackdriver to pick-up errors and associate with
the provided service.
For full details see: https://cloud.google.com/error-reporting/docs/formatting-error-messages
Fixes: #2513
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
* logging-{winston,bunyan}: accept serviceContext
Accept serviceContext option at instantiation time. This is added to
error logs to allow Stackdriver to pick-up errors and associate with
the provided service.
For full details see: https://cloud.google.com/error-reporting/docs/formatting-error-messages
Fixes: #2513
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
* logging-{winston,bunyan}: accept serviceContext
Accept serviceContext option at instantiation time. This is added to
error logs to allow Stackdriver to pick-up errors and associate with
the provided service.
For full details see: https://cloud.google.com/error-reporting/docs/formatting-error-messages
Fixes: #2513
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
* logging-{winston,bunyan}: accept serviceContext
Accept serviceContext option at instantiation time. This is added to
error logs to allow Stackdriver to pick-up errors and associate with
the provided service.
For full details see: https://cloud.google.com/error-reporting/docs/formatting-error-messages
Fixes: #2513
4 tasks
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept serviceContext option at instantiation time. This is added to
error logs to allow Stackdriver to pick-up errors and associate with
the provided service.
For full details see: https://cloud.google.com/error-reporting/docs/formatting-error-messages
Fixes: #2513