logging-winston: fix 0 priority log levels.#2533
Merged
stephenplusplus merged 3 commits intogoogleapis:masterfrom Aug 18, 2017
robotsnacks:master
Merged
logging-winston: fix 0 priority log levels.#2533stephenplusplus merged 3 commits intogoogleapis:masterfrom robotsnacks:master
0 priority log levels.#2533stephenplusplus merged 3 commits intogoogleapis:masterfrom
robotsnacks:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
ofrobots
approved these changes
Aug 16, 2017
Contributor
ofrobots
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
| } | ||
|
|
||
| if (!this.levels_[levelName]) { | ||
| if (typeof this.levels_[levelName] === 'undefined') { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
👍 Thanks for approving so quickly and removing my |
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
* logging-winston: fix `0` log levels. * logging-winston: correct lint errors. * avoid typeof
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
* logging-winston: fix `0` log levels. * logging-winston: correct lint errors. * avoid typeof
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
* logging-winston: fix `0` log levels. * logging-winston: correct lint errors. * avoid typeof
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR correct a bug causing log levels with a
0priority to throw anUnknown log level: ...error.