Skip to content

logging-winston: fix 0 priority log levels.#2533

Merged
stephenplusplus merged 3 commits intogoogleapis:masterfrom
robotsnacks:master
Aug 18, 2017
Merged

logging-winston: fix 0 priority log levels.#2533
stephenplusplus merged 3 commits intogoogleapis:masterfrom
robotsnacks:master

Conversation

@JoshuaToenyes
Copy link
Contributor

This PR correct a bug causing log levels with a 0 priority to throw an Unknown log level: ... error.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 15, 2017
@JoshuaToenyes
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 15, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9b44eb6 on RobotSnacks:master into 118b622 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling eda7d97 on RobotSnacks:master into 118b622 on GoogleCloudPlatform:master.

Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

}

if (!this.levels_[levelName]) {
if (typeof this.levels_[levelName] === 'undefined') {

This comment was marked as spam.

@JoshuaToenyes
Copy link
Contributor Author

👍 Thanks for approving so quickly and removing my typeof usage!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e3d1f84 on RobotSnacks:master into 118b622 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 0761e3f into googleapis:master Aug 18, 2017
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
* logging-winston: fix `0` log levels.

* logging-winston: correct lint errors.

* avoid typeof
GautamSharda pushed a commit that referenced this pull request Jan 20, 2026
* logging-winston: fix `0` log levels.

* logging-winston: correct lint errors.

* avoid typeof
GautamSharda pushed a commit that referenced this pull request Feb 3, 2026
* logging-winston: fix `0` log levels.

* logging-winston: correct lint errors.

* avoid typeof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging-winston cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants