storage: fix signed url tests. fixes #238#239
Merged
silvolu merged 1 commit intogoogleapis:masterfrom Sep 23, 2014
Merged
Conversation
Contributor
stephenplusplus
commented
Sep 23, 2014
stephenplusplus
commented
- Removed the regression test
- Added a test that the expiration date we passed was honored by our code. Whether that's honored upstream or not is in the hands of another library's code :)
test/storage/index.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Other than nit, LGTM |
stephenplusplus
force-pushed
the
spp--signed-url-test
branch
from
1a176ae to
df43bdd
Compare
Contributor
|
While you're at it, do you also want to add a check that expiration is not in the past, and error if that's the case? |
Contributor
Author
|
👍 Yes! |
stephenplusplus
force-pushed
the
spp--signed-url-test
branch
from
df43bdd to
0ff03a1
Compare
Contributor
Author
|
PTAL. |
Contributor
|
LGTM, merging. |
silvolu
added a commit
that referenced
this pull request
Sep 23, 2014
storage: fix signed url tests. fixes #238
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
This was referenced Oct 12, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
Source-Link: googleapis/synthtool@d229a12 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e
4 tasks
This was referenced Oct 13, 2022
Closed
Closed
Closed
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
fix(deps): update dependency arrify to v2 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | arrify | dependencies | major | [`^1.0.1` -> `^2.0.0`](https://diff.intrinsic.com/arrify/1.0.1/2.0.0) | [source](https://togithub.com/sindresorhus/arrify) | --- ### Release Notes <details> <summary>sindresorhus/arrify</summary> ### [`v2.0.0`](https://togithub.com/sindresorhus/arrify/releases/v2.0.0) [Compare Source](https://togithub.com/sindresorhus/arrify/compare/v1.0.1...v2.0.0) Breaking: - Require Node.js 8 ([#​6](https://togithub.com/sindresorhus/arrify/issues/6)) [`8d6734f`](https://togithub.com/sindresorhus/arrify/commit/8d6734f) Enhancements: - Add TypeScript definition ([#​6](https://togithub.com/sindresorhus/arrify/issues/6)) [`8d6734f`](https://togithub.com/sindresorhus/arrify/commit/8d6734f) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-translate). #239 automerged by dpebot
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
4 tasks
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
This was referenced Feb 4, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.