error-reporting: Add `errors.report` system test by DominicKramer · Pull Request #2264 · googleapis/google-cloud-node

DominicKramer · 2017-04-27T15:42:03Z

This change adds a system test that verifies that the
errors.report method correctly reports an error to the error
reporting console.

This change adds a system test that verifies that the `errors.report` method correctly reports an error to the error reporting console.

coveralls · 2017-04-27T15:53:50Z

Coverage remained the same at 100.0% when pulling e50f932 on DominicKramer:test/system-test-verify-report into 5149126 on GoogleCloudPlatform:master.

packages/error-reporting/utils/errors-api-transport.js

+        uri: [API, id, 'events'].join('/'),
+        method: 'DELETE'
+      };
+      self.request_(options, function(err, /* jshint unused:false */ response,


packages/error-reporting/system-test/testAuthClient.js

+  });
+
+  it('Should correctly publish errors', function(done) {
+    this.timeout(TIMEOUT * 2);


packages/error-reporting/system-test/testAuthClient.js

+  });
+
+  after(function(done) {
+    transport.deleteAllEvents(function(err) {


packages/error-reporting/system-test/testAuthClient.js

+          var rep = errItem.representative;
+          assert.ok(rep);
+          var context = rep.serviceContext;
+          assert.ok(context);


coveralls · 2017-05-02T18:16:23Z

Coverage remained the same at 100.0% when pulling 57bf5e9 on DominicKramer:test/system-test-verify-report into 5149126 on GoogleCloudPlatform:master.

DominicKramer · 2017-05-02T18:18:08Z

@stephenplusplus This is ready to land now.

error-reporting: Add errors.report system test

e50f932

This change adds a system test that verifies that the `errors.report` method correctly reports an error to the error reporting console.

DominicKramer added the api: error-reporting label Apr 27, 2017

DominicKramer requested a review from matthewloring April 27, 2017 15:42

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2017

DominicKramer mentioned this pull request Apr 27, 2017

error-reporting: Add end-to-end tests #2257

Closed

stephenplusplus reviewed Apr 27, 2017

View reviewed changes

matthewloring suggested changes Apr 28, 2017

View reviewed changes

Add a code comment to address a GitHub comment

57bf5e9

matthewloring approved these changes May 2, 2017

View reviewed changes

stephenplusplus merged commit 0f10a12 into googleapis:master May 2, 2017

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

error-reporting: Add errors.report system test (#2264)

b573b29

GautamSharda pushed a commit that referenced this pull request Jan 15, 2026

error-reporting: Add errors.report system test (#2264)

0f074c2

GautamSharda mentioned this pull request Jan 20, 2026

chore: migrate code from googleapis/nodejs-error-reporting #7019

Closed

4 tasks

GautamSharda pushed a commit that referenced this pull request Feb 5, 2026

error-reporting: Add errors.report system test (#2264)

10da642

GautamSharda mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-error-reporting #7169

Open

4 tasks

Conversation

DominicKramer commented Apr 27, 2017

Uh oh!

coveralls commented Apr 27, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented May 2, 2017

Uh oh!

DominicKramer commented May 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants