Use WARN as the default error-reporting logging level#2237
Merged
DominicKramer merged 5 commits intogoogleapis:masterfrom Apr 20, 2017
Merged
Use WARN as the default error-reporting logging level#2237DominicKramer merged 5 commits intogoogleapis:masterfrom
error-reporting logging level#2237DominicKramer merged 5 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
stephenplusplus
requested review from
ofrobots
and removed request for
stephenplusplus
| } | ||
| }; | ||
| }); | ||
| afterEach(function() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The `.jshintignore` and `.jshintrc` files in this directory were conflicting with the `.jshintignore` and `.jshintrc` files in the `google-cloud-node` repo's root directory.
ofrobots
approved these changes
Apr 20, 2017
| assert.strictEqual(text, | ||
| 'WARN:@google/cloud-errors: test warning message'); | ||
| }); | ||
| it('Should be able to ERROR by default', function() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
Fixes #2236: If the logging level is not specified when configuring the `error-reporting` library, warning messages are not displayed to the user.
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
Fixes #2236: If the logging level is not specified when configuring the `error-reporting` library, warning messages are not displayed to the user.
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 5, 2026
Fixes #2236: If the logging level is not specified when configuring the `error-reporting` library, warning messages are not displayed to the user.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2236: If the logging level is not specified when configuring the
error-reportinglibrary, warning messages are not displayed to the user.