Skip to content

Implement _writev for the bunyan write stream#2198

Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom
ofrobots:bunyan-writev
Apr 11, 2017
Merged

Implement _writev for the bunyan write stream#2198
stephenplusplus merged 2 commits intogoogleapis:masterfrom
ofrobots:bunyan-writev

Conversation

@ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Apr 10, 2017

This adds support for _writev to allow bulk writing from the WritableStream.

Fixes: #2135

ofrobots added 2 commits April 10, 2017 13:57
@ofrobots
logging-bunyan: write instead of log_[severity]
6158510 
This optimizes the path somewhat, along with making it easier to
implement _writev in a subsequent change.
@ofrobots
logging-bunyan: implement _writev as well
5baf51b 
Fixes: googleapis#2135
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2017
@coveralls
Copy link

coveralls commented Apr 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5baf51b on ofrobots:bunyan-writev into 021a97d on GoogleCloudPlatform:master.

@ofrobots ofrobots mentioned this pull request Apr 10, 2017
Closed
@stephenplusplus stephenplusplus merged commit 8d9b607 into googleapis:master Apr 11, 2017
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Apr 11, 2017

@ofrobots we have a broken system test:

1) LoggingBunyan should properly write log entries:

      Uncaught AssertionError: 0 === 4
      + expected - actual

      -0
      +4
      
      at system-test/logging-bunyan.js:122:16
      at node_modules/@google-cloud/logging/src/index.js:318:5
      at node_modules/@google-cloud/logging/node_modules/@google-cloud/common-grpc/src/service.js:318:5
      at onResponse (node_modules/@google-cloud/logging/node_modules/@google-cloud/common-grpc/node_modules/retry-request/index.js:120:7)
      at Object.callback (node_modules/@google-cloud/logging/node_modules/@google-cloud/common-grpc/src/service.js:307:11)
      at node_modules/@google-cloud/logging/node_modules/@google-cloud/common-grpc/node_modules/grpc/src/node/src/client.js:439:14

Would you mind taking a look?

@ofrobots
Copy link
Contributor Author

ofrobots commented Apr 11, 2017

Ack. Looking.

@ofrobots
Copy link
Contributor Author

ofrobots commented Apr 11, 2017

#2201. Apologies for not running the system test.

@ofrobots ofrobots deleted the bunyan-writev branch April 11, 2017 00:43
miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026
@ofrobots @stephenplusplus
Implement _writev for the bunyan write stream (#2198)
9aab6e3 
* logging-bunyan: write instead of log_[severity]

This optimizes the path somewhat, along with making it easier to
implement _writev in a subsequent change.
This was referenced Jan 14, 2026
Closed
Closed
Closed
sofisl pushed a commit that referenced this pull request Feb 4, 2026
@ofrobots @stephenplusplus
Implement _writev for the bunyan write stream (#2198)
2a9f7b2 
* logging-bunyan: write instead of log_[severity]

This optimizes the path somewhat, along with making it easier to
implement _writev in a subsequent change.
This was referenced Feb 4, 2026
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: logging-bunyan cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ofrobots @coveralls @stephenplusplus @googlebot