Skip to content

docs: update script parser for error-reporting #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 3 commits into from
Apr 4, 2017
Merged

docs: update script parser for error-reporting #2181

stephenplusplus merged 3 commits into from
Apr 4, 2017

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Apr 3, 2017 •
edited by stephenplusplus
Loading

RE: #2017

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2017
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Apr 3, 2017

I asked if the ER PR could just move index.js to src/ so we wouldn't need any special handling.

@callmehiphop
Copy link
Contributor Author

callmehiphop commented Apr 3, 2017

@stephenplusplus nice, I'll update this PR once that gets resolved then!

@coveralls
Copy link

coveralls commented Apr 3, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 12a4ce2 on callmehiphop:dg--doc-parser-updates into 65b0660 on GoogleCloudPlatform:master.

@callmehiphop
Copy link
Contributor Author

callmehiphop commented Apr 4, 2017

@stephenplusplus I've updated the PR.

@coveralls
Copy link

coveralls commented Apr 4, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 90c67aa on callmehiphop:dg--doc-parser-updates into 65b0660 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit d765148 into googleapis:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

Assignees

No one assigned

Labels

api: error-reporting cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@callmehiphop @stephenplusplus @coveralls @googlebot