GA and Beta Promotions by lukesneeringer · Pull Request #2165 · googleapis/google-cloud-node

lukesneeringer · 2017-03-30T20:14:13Z

This:

~~bumps the versions of logging, datastore, and storage to 1.0.0~~
designates ~~the aforementioned~~ Storage as GA, and translation and language as beta
~~bumps engines.node to >= 4.0.0, and therefore the semver major of literally everything (see discussion)~~

lukesneeringer · 2017-03-30T20:23:02Z

@stephenplusplus Is there a right way to deal with the CI version dependency problem?

README.md


-This client supports the following Google Cloud Platform services at a [Beta](#versioning) quality level:
+This client supports the following Google Cloud Platform services
+at a [GA](#versioning) quality level:


README.md

+versioned 0.x.y is subject to backwards incompatible changes at any time.
+
+**GA**: Libraries defined at the GA (general availability) quality level
+are stable, and that the code surface will not change in


packages/bigtable/package.json

-    "@google-cloud/common": "^0.12.0",
-    "@google-cloud/common-grpc": "^0.2.1",
+    "@google-cloud/common": "^0.13.0",
+    "@google-cloud/common": "^0.3.0",


circle.yml

+dependencies:
+  pre:
+    - npm install packages/common/
+    - npm install packages/common-grpc/


packages/bigtable/package.json

    "concat-stream": "^1.5.0",
    "create-error-class": "^3.0.2",
-    "dot-prop": "^3.0.0",
+    "dot-prop": "^4.1.1",


packages/bigtable/package.json

 {
  "name": "@google-cloud/bigtable",
-  "version": "0.8.0",
+  "version": "0.9.0",


coveralls · 2017-03-31T15:21:37Z

Coverage remained the same at 99.987% when pulling 657b50e on 1.0 into 0b2c4c3 on master.

googlebot · 2017-03-31T16:23:48Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

coveralls · 2017-03-31T16:45:10Z

Coverage remained the same at 99.987% when pulling db223ed on 1.0 into 0b2c4c3 on master.

lukesneeringer self-assigned this Mar 30, 2017

lukesneeringer requested review from callmehiphop, jmuk and stephenplusplus March 30, 2017 20:14

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2017

stephenplusplus reviewed Mar 30, 2017

View reviewed changes

lukesneeringer commented Mar 30, 2017

View reviewed changes

README.md Outdated

versioned 0.x.y is subject to backwards incompatible changes at any time.

**GA**: Libraries defined at the GA (general availability) quality level

are stable, and that the code surface will not change in

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed Mar 31, 2017

View reviewed changes

packages/bigtable/package.json Outdated

"@google-cloud/common": "^0.12.0",

"@google-cloud/common-grpc": "^0.2.1",

"@google-cloud/common": "^0.13.0",

"@google-cloud/common": "^0.3.0",

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed Mar 31, 2017

View reviewed changes

circle.yml Outdated

dependencies:

pre:

- npm install packages/common/

- npm install packages/common-grpc/

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed Mar 31, 2017

View reviewed changes

packages/bigtable/package.json Outdated

"concat-stream": "^1.5.0",

"create-error-class": "^3.0.2",

"dot-prop": "^3.0.0",

"dot-prop": "^4.1.1",

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed Mar 31, 2017

View reviewed changes

stephenplusplus force-pushed the 1.0 branch from 657b50e to fdaa647 Compare March 31, 2017 16:23

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 31, 2017

stephenplusplus force-pushed the 1.0 branch from fdaa647 to 98283a1 Compare March 31, 2017 16:28

stability guarantee promotions

db223ed

stephenplusplus force-pushed the 1.0 branch from 98283a1 to db223ed Compare March 31, 2017 16:33

stephenplusplus merged commit 24e5426 into master Mar 31, 2017

lukesneeringer deleted the 1.0 branch March 31, 2017 16:45

sofisl pushed a commit that referenced this pull request Oct 11, 2022

stability guarantee promotions (#2165)

6d2cf69

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

stability guarantee promotions (#2165)

0b1d0ae

sofisl pushed a commit that referenced this pull request Nov 10, 2022

stability guarantee promotions (#2165)

a368b3a

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

stability guarantee promotions (#2165)

20277d9

Conversation

lukesneeringer commented Mar 30, 2017 • edited by stephenplusplus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukesneeringer commented Mar 30, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 31, 2017

Uh oh!

googlebot commented Mar 31, 2017

Uh oh!

coveralls commented Mar 31, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lukesneeringer commented Mar 30, 2017 •

edited by stephenplusplus

Loading