Skip to content

logging-bunyan: make it a proper Writeable stream #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 3 commits into from
Mar 22, 2017
Merged

logging-bunyan: make it a proper Writeable stream #2117

stephenplusplus merged 3 commits into from
Mar 22, 2017

Conversation

@ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Mar 20, 2017 •
edited
Loading

Fixes: #1988

NOTE: the system test is still dependent on the unreleased removeCircular fixes in @google-cloud/logging.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2017
@coveralls
Copy link

coveralls commented Mar 21, 2017

Coverage Status

Changes Unknown when pulling 300a4d7 on ofrobots:bunyan-writable into ** on GoogleCloudPlatform:master**.

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Mar 21, 2017 •
edited
Loading

Sorry for popping this question in here, but is the logging-winston code on master ready to be updated @google-cloud/logging@0.8.0?

@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 21, 2017

Yes it is; but I was waiting for the next release of @google-cloud/logging – as I am waiting for the removeCircular changes to be released before updating logging-winston.

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Mar 21, 2017

Alright, lemme do that.

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Mar 21, 2017

Published @google-cloud/logging@0.8.1

@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 21, 2017

Bumped the logging dependency to 0.8.1 for logging-bunyan here. Will open a separate PR for bumping it for logging-winston.

@coveralls
Copy link

coveralls commented Mar 22, 2017

Coverage Status

Coverage increased (+6.0e-05%) to 99.924% when pulling 419d42c on ofrobots:bunyan-writable into 676282a on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus suggested changes Mar 22, 2017
View reviewed changes
packages/logging-bunyan/src/index.js Outdated
* Format a bunyan record into a Stackdriver log entry.
*
* @param {object} record - Bunyan log record.
* @param {object} - Bunyan log record.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/logging-bunyan/src/index.js Outdated
* @private
*/
LoggingBunyan.prototype.write = function(record) {
LoggingBunyan.prototype._formatEntry = function(record) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/logging-bunyan/test/index.js Outdated
done();
};

loggingBunyan._write(RECORD, '', assert.ifError);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/logging-bunyan/test/index.js Outdated
});
});


This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/logging-bunyan/test/index.js Outdated
};
}

function fakeWritable(options) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Mar 22, 2017

Coverage Status

Coverage increased (+6.0e-05%) to 99.924% when pulling bad1206 on ofrobots:bunyan-writable into 676282a on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 922e151 into googleapis:master Mar 22, 2017
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Mar 22, 2017

Thanks!

@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 22, 2017

Thank you! Would it be possible to get updated winston and bunyan modules published to npm?

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Mar 22, 2017

Sure thing, I'll do that now.

@ofrobots ofrobots deleted the bunyan-writable branch March 22, 2017 17:48
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Mar 22, 2017

Both are out as 0.2.0's.

miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026
@ofrobots @stephenplusplus
logging-bunyan: make it a proper Writeable stream (#2117)
0a7d2e2
This was referenced Jan 14, 2026
Closed
Closed
Closed
sofisl pushed a commit that referenced this pull request Feb 4, 2026
@ofrobots @stephenplusplus
logging-bunyan: make it a proper Writeable stream (#2117)
6f95603
This was referenced Feb 4, 2026
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephenplusplus stephenplusplus stephenplusplus requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: logging-bunyan cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

logging-bunyan should be a proper Writable stream

4 participants

@ofrobots @coveralls @stephenplusplus @googlebot