site: make the doc link more linky.#202
Conversation
|
Dude. 🏄 I think the animation is awesome. Only thing that threw me off was that 'See the' is rather light & isn't blue. Making it blue doesn't look amazing but it certainly is a step up. Perhaps making the text darker is the best way. A change of alpha from 0.8 to 0.95 was better IMO. Before (0.8 alpha):
After (0.95 alpha):
|
|
Woo! I'm somewhat partial to the lighter gray, but I don't mind it either way. I'll wait for more weigh-ins before making any changes for now. |
|
@leomaia - please let me know your thoughts. The last thing I want to do is ruin your code and style. Happy to make any changes to maintain the integrity 👍 |
|
Certainly not a deal breaker. It's much clearer and more |
|
@stephenplusplus I liked the animation but I am not sure about the element around the icon in the middle of the phrase. I don't know what happened but the white space (padding) between the sections seems to be cut on half and this makes me not being a fan of the light grey bar for the external links either. They are all very close together. If you set this bar (.featuring-links) to display: inline-block it will stop spanning full width and will feel more comfortable for me. I made a rough example.
|
|
Looks nice to me! I'll try to re-create :) |
stephenplusplus
force-pushed
the
doc-button
branch
from
297cd57 to
7efd8bd
Compare
|
Take another look: http://stephenplusplus.github.io/gcloud-node/#/ |
|
Loving the animation. Can we keep the red button with this animation on hover please? Having a single section of buttons was making it looking slicker -- less vertical alignment issues I suppose :) |
|
Yeah animation is good but the text should change in some way when you hover. Right now it's underlined statically and that doesn't change. :( |
|
@rakyll So identical to http://googlecloudplatform.github.io/gcloud-node/#/, with just the box icon spinning on hover? |
|
@stephenplusplus, yeap, that's just my personal opinion though :) |
|
I'm against that. It looks pressed / current page. I want to see a blue link / fat button in my face to take me to documentation. Landing page is the last place we want people to abandon. And centering the button/link basically screams "CLICK ME". It's the "download me" equivalent for an API client: Sources: I'd rather it be ugly than confuse people. |
|
The button can say "Read Docs". |
|
SGTM. |
|
My thoughts on how much we are thinking about this button: (╯°□°）╯︵ ┻━┻) |
|
So where are we at? Identical to master + spinning icon + "Read the Docs" On Thursday, September 11, 2014, Ryan Seys notifications@github.com wrote:
|
|
Yes, exactly. |
|
This button is going to win awards. On Thursday, September 11, 2014, Ryan Seys notifications@github.com wrote:
|
|
I hope we bring down google analytics because people are clicking it so much. |
|
Up to the dated: http://stephenplusplus.github.io/gcloud-node/#/ |
|
|
site: make the doc link more linky.
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5f7f9c6d-c75a-4c60-8bb8-0026a14cead7/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@bd0deaa
* feat: auto-generate samples for GAPIC clients PiperOrigin-RevId: 398106791 Source-Link: googleapis/googleapis@4f46ddc Source-Link: googleapis/googleapis-gen@43a09fa Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNhMDlmYWNiYTBlNWM4MGQyNTg3NzI0ZDdlZjIxYmU5MGUwYjE4YyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* build: check dead links on Kokoro * recursive crawl local links
* chore: fix `npm` for Node v18 samples tests chore: fix `npm` for samples tests Source-Link: googleapis/synthtool@4d75242 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:0d39e59663287ae929c1d4ccf8ebf7cef9946826c9b86eda7e85d8d752dbb584 * chore!: upgrade to node 18 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update workflow * downgrade arborist * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * downgrade packlist * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * downgrade rimraf * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * downgrade execa * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * downgrade execa * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix execa * execa * downgrade execa * downgrade * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * restore execa * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * run lint --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <sofialeon@google.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://togithub.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#​801--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#​4328](https://togithub.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@​boneskull**](https://togithub.com/boneskull)) ### [`v8.0.0`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#​800--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@​giltayar**](https://togithub.com/giltayar) and [**@​nicojs**](https://togithub.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#​4164](https://togithub.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@​UlisesGascon**](https://togithub.com/UlisesGascon)) - [#​4175](https://togithub.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@​juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#​4260](https://togithub.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@​craigtaub**](https://togithub.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#​4315](https://togithub.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@​juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#​4309](https://togithub.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@​juergba**](https://togithub.com/juergba)) - [#​4282](https://togithub.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@​arvidOtt**](https://togithub.com/arvidOtt)) - [#​4223](https://togithub.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@​juergba**](https://togithub.com/juergba)) - [#​4178](https://togithub.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@​wnghdcjfe**](https://togithub.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#​4245](https://togithub.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@​boneskull**](https://togithub.com/boneskull)) ❗ See also [#​4244](https://togithub.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#​4304](https://togithub.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@​JacobLey**](https://togithub.com/JacobLey)) - [#​4299](https://togithub.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@​giltayar**](https://togithub.com/giltayar)) #### 📖 Documentation - [#​4246](https://togithub.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@​boneskull**](https://togithub.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-promisify).
5 participants
RE: #183
I may have gone a little overboard with this one.
http://stephenplusplus.github.io/gcloud-node/#/