support global configuration.#196
Conversation
test/storage/index.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
edc53b7 to
e2e0931
Compare
package.json
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Other than a few small blips I've addressed in comments, this LGTM. Would like clarification on how the type of If I call |
|
Also, docs are 🏀'n |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Note: will need to add special handling of "credentials" vs "keyFIlename" for this case: var gcloud = require('gcloud')({ keyFilename: '/file.json' });
var dataset = gcloud.datastore.dataset({ credentials: {} }); |
47906ed to
009ae90
Compare
|
Updated the PR to add handling for connection details overriding. Also updated my gh-pages branch: http://stephenplusplus.github.io/gcloud-node/#/docs |
* First draft of streaming insert sample * Fix flaky test + address comments * Fix comments * Fix flaky test
#191
#172
Here we go!
http://stephenplusplus.github.io/gcloud-node/#/docs explains a lot of this for me :)
But, key points:
newuse from dataset & storageThese changes went hand in hand.
Smaller changes: