bigquery: fix structs for SQL parameter queries#1869
Merged
callmehiphop merged 1 commit intogoogleapis:masterfrom Dec 7, 2016
Merged
bigquery: fix structs for SQL parameter queries#1869callmehiphop merged 1 commit intogoogleapis:masterfrom
callmehiphop merged 1 commit intogoogleapis:masterfrom
Conversation
stephenplusplus
added
api: bigquery
googlebot
added
the
cla: yes
callmehiphop
reviewed
Dec 7, 2016
| 'This value could not be translated to a BigQuery data type.', | ||
| value | ||
| ].join('\n')); | ||
| return { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Do we want to document this for the users? |
Contributor
Author
|
Do you mean show how to use a struct in a query? I don't think we need to show every type, since we also have arrays, Booleans, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1868 (comment)
Structs weren't being prepared correctly. We now have system tests for every type.
(Thanks, @c0b!)