Add system-test for GAPIC files for logging API.#1865
Add system-test for GAPIC files for logging API.#1865jmuk wants to merge 2 commits intogoogleapis:masterfrom
Conversation
This is hand-written for now. Eventually, we will replace this by automatically generated ones.
|
Some linting errors: |
|
Fixed lint errors. |
|
@jmuk is it possible these tests are better suited for the gax repo? As I understand this, these tests are certifying that the gax library works. But, we should always be able to assume it works, because there wouldn't have been a gax release unless tests like these passed. Does this make sense? |
|
This is a bit different from gax-nodejs repo because it tests API-agnostic logic, while our code generator tests the generated files, character-by-character. This PR verifies the behaviors of generated files -- i.e. whether it's syntactically correct or not, or whether it can issue API calls correctly or not. However we have another repository Feel free to close this if that sounds good. |
|
Thanks, |
This is hand-written for now. Eventually, we will replace this
by automatically generated ones.