Skip to content

core: make operations promise friendly#1689

Merged
stephenplusplus merged 5 commits intogoogleapis:promise-supportfrom
callmehiphop:promise-support-3
Oct 14, 2016
Merged

core: make operations promise friendly#1689
stephenplusplus merged 5 commits intogoogleapis:promise-supportfrom
callmehiphop:promise-support-3

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Oct 14, 2016 •
edited
Loading

This makes operations Promise friendly. By default they are still EventEmitter instances, but now include a .promise() method as a convenience.

bigquery.startQuery(query)
  .then(function(data) {
    var job = data[0];
    return job.promise();
  })
  .then(function(data) {
    var metadata = data[0];
  }, function(err) {
    // Something went wrong!
  });

With Bluebird

bigquery.startQuery(query)
  .spread(function(job) {
    return job.promise();
  })
  .spread(function(metadata) {
    // yay
  });

In Node >= 6.0:

bigquery.startQuery(query)
  .then([job] => job.promise())
  .then([metadata] => {}, err => {});

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2016
stephenplusplus
stephenplusplus reviewed Oct 14, 2016
View reviewed changes
packages/common/src/grpc-operation.js Outdated
* Wraps the `complete` and `error` events in a Promise.
*
* @return {promise}
*/

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/bigquery/src/job.js Outdated
* }, function(err) {
* // An error occurred during the job.
* });
*/

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Oct 14, 2016

Idea and code lgtm.

stephenplusplus
stephenplusplus reviewed Oct 14, 2016
View reviewed changes
packages/bigquery/src/job.js
*/
Job.prototype.promise = function() {
var self = this;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@callmehiphop
Copy link
Contributor Author

callmehiphop commented Oct 14, 2016

@stephenplusplus tests have been added, PTAL!

stephenplusplus
stephenplusplus suggested changes Oct 14, 2016
View reviewed changes
packages/bigquery/src/job.js
Job.prototype.promise = function() {
var self = this;

return new self.Promise(function(resolve, reject) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/common/src/grpc-operation.js
GrpcOperation.prototype.promise = function() {
var self = this;

return new self.Promise(function(resolve, reject) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus merged commit 340f3d8 into googleapis:promise-support Oct 14, 2016
callmehiphop added a commit that referenced this pull request Oct 14, 2016
@callmehiphop
core: make operations promise friendly (#1689)
6899963
@stephenplusplus stephenplusplus mentioned this pull request Oct 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephenplusplus stephenplusplus stephenplusplus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@callmehiphop @stephenplusplus @googlebot