storage: allow custom file encryption#1364
Conversation
lib/storage/file.js
Outdated
| return { | ||
| key: key, | ||
| hash: crypto.createHash('sha256').update(key, 'base64').digest('base64') | ||
| }; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Just to confirm, the goal here is to be able to set a key when uploading a file. Eventually we might want a key-derivation library involved, but for now this is just about setting a key on a per-file basis. |
|
Let me know how far off #1364 (comment) is from what you're looking for. |
|
If we only support uploading a file, the user would be blocked out from other operations, like downloading it. The way this PR works is:
|
| * }); | ||
| * }); | ||
| * }); | ||
| */ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
4f84239 to
87d040b
Compare
87d040b to
1470353
Compare
|
@callmehiphop PTAL! |
|
@stephenplusplus I think npm might have messed up your most recent release of |
|
Fixed... v0.7.1. |
|
This might be a slightly off-topic question, but the upstream documentation for sending encryption keys also mentions a separate set of headers for |
|
|
|
Done! #1373 |
|
Changes Unknown when pulling 6e1df56 on stephenplusplus:spp--1361 into * on GoogleCloudPlatform:master*. |
* storage: allow custom file encryption * npm publish woes.
Fixes #1361
To Dos
options.encryptionin gcs-resumable-upload