datastore: support deferred results. fixes #77.#133
Merged
rakyll merged 1 commit intogoogleapis:masterfrom Aug 27, 2014
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
deferred
branch
from
ceb8122 to
473f55d
Compare
Contributor
Author
|
@rakyll Rebased, should be good to merge 👍 |
rakyll
pushed a commit
that referenced
this pull request
Aug 27, 2014
datastore: support deferred results. fixes #77.
Contributor
|
Great, thanks! |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
This was referenced Oct 5, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
This was referenced Oct 12, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
…or (#133) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2b12f6c9-10d8-4a5e-b86e-af5827858559/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@ba9918c
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
This was referenced Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 29, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
This was referenced Feb 4, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 5, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 5, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought I'd take a stab at #77. If a response from a
dataset.getcomes back with deferred keys, this will recursively call .get again, only executing the callback passed to the initial .get once, after having gathered all possible results.