datastore: Namespace should be a dataset-level configuration by rakyll · Pull Request #122 · googleapis/google-cloud-node

rakyll · 2014-08-20T21:28:37Z

No description provided.

…nto namespace Conflicts: package.json

silvolu · 2014-08-22T19:09:04Z

The namespace features have been implemented in #124, and my understanding is that you liked that approach better, so I merged that one.
I see other things in this PR, anything you want to salvage?

lib/datastore/dataset.js

rakyll · 2014-08-26T02:56:55Z

@rakyll it does feel a little more natural to keep int and double on the Dataset, since a user shouldn't be using them outside of the scope of a dataset. Want me to send a PR with this? Instead of on the prototype, we could make them static (Dataset.int).

+1 to Dataset and static.

rakyll · 2014-08-26T02:58:01Z

Sorry I meant Datastore and static. Datastore.int.

stephenplusplus · 2014-08-26T02:58:49Z

I think that's what we have now, right? :)

On Monday, August 25, 2014, Burcu Dogan notifications@github.com wrote:

Sorry I meant Datastore and static. Datastore.int.

—
Reply to this email directly or view it on GitHub
#122 (comment)
.

rakyll · 2014-08-26T04:16:03Z

Do you want to eliminate the additional require for int and double?

It's a legitimate reason, otherwise it's not weird to have them at datastore level. They are datastore types in the end of the day.

stephenplusplus · 2014-08-26T12:21:47Z

Do you mean define the Int and Double classes directly in lib/datastore/index.js? I think I'm actually ok with the current setup. Keeping Int & Double in entity makes sense to me, and having the builder on the datastore object also works.

On another note, was there anything else in this PR I missed that we should save?

rakyll · 2014-08-27T17:12:07Z

Keeping Int & Double in entity makes sense to me, and having the builder on the datastore object also works.

Yes, better to keep in the entity. There is nothing else to do in the scope of this change. I'm closing this PR.

🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/nodejs-artifact-registry@v1.2.3...v1.3.0) (2022-03-23) ### Features * promote v1beta2 features to v1 ([#132](googleapis/nodejs-artifact-registry#132)) ([a217d2e](googleapis/nodejs-artifact-registry@a217d2e)) * upgrade to GA ([#96](googleapis/nodejs-artifact-registry#96)) ([1e71407](googleapis/nodejs-artifact-registry@1e71407)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…ncy versions (#122) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/0832b96d-f20d-428a-9244-9373d24004a9/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@fdd03c1

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webpack-cli](https://togithub.com/webpack/webpack-cli) | devDependencies | major | [`^3.3.10` -> `^4.0.0`](https://renovatebot.com/diffs/npm/webpack-cli/3.3.12/4.0.0) | --- ### Release Notes <details> <summary>webpack/webpack-cli</summary> ### [`v4.0.0`](https://togithub.com/webpack/webpack-cli/blob/master/CHANGELOG.md#400-httpsgithubcomwebpackwebpack-clicomparewebpack-cli400-rc1webpack-cli400-2020-10-10) [Compare Source](https://togithub.com/webpack/webpack-cli/compare/v3.3.12...webpack-cli@4.0.0) ##### Bug Fixes - add compilation lifecycle in watch instance ([#1903](https://togithub.com/webpack/webpack-cli/issues/1903)) ([02b6d21](https://togithub.com/webpack/webpack-cli/commit/02b6d21eaa20166a7ed37816de716b8fc22b756a)) - cleanup `package-utils` package ([#1822](https://togithub.com/webpack/webpack-cli/issues/1822)) ([fd5b92b](https://togithub.com/webpack/webpack-cli/commit/fd5b92b3cd40361daec5bf4486e455a41f4c9738)) - cli-executer supplies args further up ([#1904](https://togithub.com/webpack/webpack-cli/issues/1904)) ([097564a](https://togithub.com/webpack/webpack-cli/commit/097564a851b36b63e0a6bf88144997ef65aa057a)) - exit code for validation errors ([59f6303](https://togithub.com/webpack/webpack-cli/commit/59f63037fcbdbb8934b578b9adf5725bc4ae1235)) - exit process in case of schema errors ([71e89b4](https://togithub.com/webpack/webpack-cli/commit/71e89b4092d953ea587cc4f606451ab78cbcdb93)) ##### Features - assign config paths in build dependencies in cache config ([#1900](https://togithub.com/webpack/webpack-cli/issues/1900)) ([7e90f11](https://togithub.com/webpack/webpack-cli/commit/7e90f110b119f36ef9def4f66cf4e17ccf1438cd)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-recommender).

Fixes: #121

* fix: drop support for node.js 4.x and 9.x * moar fixing

Fixes: #121

* fix: drop support for node.js 4.x and 9.x * moar fixing

Fixes: #121

rakyll added 3 commits August 20, 2014 11:05

Adding key.json to npmignore.

9afc6b1

datastore: Namespace should be a dataset-level configuration.

2176aea

Fixes googleapis#116.

Merge branch 'master' of github.com:GoogleCloudPlatform/gcloud-node i…

c393243

…nto namespace Conflicts: package.json

stephenplusplus reviewed Aug 26, 2014
View reviewed changes

lib/datastore/dataset.js

This comment was marked as spam.

Sign in to view

stephenplusplus mentioned this pull request Aug 27, 2014

push latest code to NPM #142

Closed

rakyll closed this Aug 27, 2014

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore: nyc ignore build/test by default (#122)

d614f39

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: nyc ignore build/test by default (#122)

e62146d

This was referenced Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

migrate code from googleapis/nodejs-os-login #3389

Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore: nyc ignore build/test by default (#122)

1c3e877

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: include build in eslintignore (#122)

b03b1cd

This was referenced Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

migrate code from googleapis/nodejs-monitoring-dashboards #3408

Merged

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-recommender #3409

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

docs(node): support "stable"/"preview" release level (#1312) (#122)

5723ef3

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-bigquery-reservation #3413

Merged

4 tasks

miguelvelezsa mentioned this pull request Jan 14, 2026

migrate code from googleapis/nodejs-logging-bunyan #6991

Closed

miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026

fix: logged errors are reported to error reporting (#122)

c9dff5f

Fixes: #121

miguelvelezsa mentioned this pull request Jan 14, 2026

migrate code from googleapis/nodejs-logging-bunyan #6995

Closed

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

chore: update package locks (#122)

9e73694

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

fix: drop support for node.js 9.x (#122)

b71439c

* fix: drop support for node.js 4.x and 9.x * moar fixing

GautamSharda pushed a commit that referenced this pull request Jan 15, 2026

chore: update package locks (#122)

2fa2d91

GautamSharda pushed a commit that referenced this pull request Jan 20, 2026

fix: drop support for node.js 9.x (#122)

25f0296

* fix: drop support for node.js 4.x and 9.x * moar fixing

GautamSharda mentioned this pull request Jan 20, 2026

chore: migrate code from googleapis/nodejs-error-reporting #7019

Closed

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jan 21, 2026

fix: logged errors are reported to error reporting (#122)

880ec86

Fixes: #121

miguelvelezsa mentioned this pull request Jan 21, 2026

migrate code from googleapis/nodejs-logging-bunyan #7021

Closed

GautamSharda pushed a commit that referenced this pull request Jan 21, 2026

fix: drop support for node.js 9.x (#122)

88f7a7e

* fix: drop support for node.js 4.x and 9.x * moar fixing

GautamSharda mentioned this pull request Jan 21, 2026

chore: migrate code from googleapis/nodejs-logging-winston #7024

Closed

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026

fix(deps): update dependency yargs to v12 (#122)

a926fd3

miguelvelezsa mentioned this pull request Jan 28, 2026

migrate code from googleapis/nodejs-datastore #7053

Closed

miguelvelezsa pushed a commit that referenced this pull request Jan 29, 2026

build: remove unused clang format (#122)

4be11a8

miguelvelezsa mentioned this pull request Jan 29, 2026

migrate code from googleapis/nodejs-promisify #7059

Closed

GautamSharda pushed a commit that referenced this pull request Feb 2, 2026

fix: drop support for node.js 9.x (#122)

ea05d60

* fix: drop support for node.js 4.x and 9.x * moar fixing

GautamSharda mentioned this pull request Feb 2, 2026

migrate code from googleapis/nodejs-logging-winston #7082

Closed

sofisl pushed a commit that referenced this pull request Feb 3, 2026

fix: drop support for node 4.x and 9.x (#122)

9df4b85

sofisl mentioned this pull request Feb 3, 2026

migrate code from googleapis/nodejs-bigquery #7111

Merged

4 tasks

GautamSharda pushed a commit that referenced this pull request Feb 3, 2026

fix: drop support for node.js 9.x (#122)

f1766a9

* fix: drop support for node.js 4.x and 9.x * moar fixing

GautamSharda mentioned this pull request Feb 3, 2026

migrate code from googleapis/nodejs-logging-winston #7129

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Feb 4, 2026

fix: logged errors are reported to error reporting (#122)

c07aa65

Fixes: #121

This was referenced Feb 4, 2026

migrate code from googleapis/nodejs-logging-bunyan #7136

Closed

migrate code from googleapis/nodejs-logging-bunyan #7137

Closed

migrate code from googleapis/nodejs-logging-bunyan #7138

Merged

migrate code from googleapis/nodejs-datastore #7148

Open

sofisl pushed a commit that referenced this pull request Feb 5, 2026

fix(deps): update dependency yargs to v12 (#122)

e0e4fd9

GautamSharda pushed a commit that referenced this pull request Feb 5, 2026

chore: update package locks (#122)

fcddc9f

GautamSharda mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-error-reporting #7169

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datastore: Namespace should be a dataset-level configuration#122

datastore: Namespace should be a dataset-level configuration#122
rakyll wants to merge 3 commits intogoogleapis:masterfrom
rakyll:namespace

rakyll commented Aug 20, 2014

Uh oh!

silvolu commented Aug 22, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

rakyll commented Aug 26, 2014

Uh oh!

rakyll commented Aug 26, 2014

Uh oh!

stephenplusplus commented Aug 26, 2014

Uh oh!

rakyll commented Aug 26, 2014

Uh oh!

stephenplusplus commented Aug 26, 2014

Uh oh!

rakyll commented Aug 27, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rakyll commented Aug 20, 2014

Uh oh!

silvolu commented Aug 22, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

rakyll commented Aug 26, 2014

Uh oh!

rakyll commented Aug 26, 2014

Uh oh!

stephenplusplus commented Aug 26, 2014

Uh oh!

rakyll commented Aug 26, 2014

Uh oh!

stephenplusplus commented Aug 26, 2014

Uh oh!

rakyll commented Aug 27, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants