Skip to content

deps: google-cloud-clients should not import google-cloud-bom #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 3 commits into from
Nov 26, 2019
Merged

deps: google-cloud-clients should not import google-cloud-bom #6903

chingor13 merged 3 commits into from
Nov 26, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Nov 26, 2019 •
edited
Loading

The clients published from this repo should not depend upon the google-cloud-bom which includes these clients.

In this PR:

  • google-cloud-clients parent pom no longer imports the google-cloud-bom
  • google-cloud-clients parent pom now dependency manages google-cloud-core, gax, iam and common protos
  • google-cloud-clients parent pom no longer dependency manages versions for artifacts used by a single client (apiary client versions)
  • updates gax to 1.50.1 for dependency convergence

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2019
@codecov
Copy link

codecov bot commented Nov 26, 2019 •
edited
Loading

Codecov Report

Merging #6903 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6903      +/-   ##
============================================
+ Coverage     41.04%   41.04%   +<.01%     
  Complexity     5289     5289              
============================================
  Files           360      360              
  Lines         50413    50413              
  Branches       6913     6913              
============================================
+ Hits          20692    20693       +1     
  Misses        28244    28244              
+ Partials       1477     1476       -1
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.12% <0%> (+0.51%) 23% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06cd90a...c6f5175. Read the comment docs.

@chingor13 chingor13 marked this pull request as ready for review November 26, 2019 16:54
@chingor13 chingor13 requested a review from a team November 26, 2019 17:06
elharo
elharo reviewed Nov 26, 2019
View reviewed changes
@chingor13
google-cloud-examples should let the google-cloud-bom handle versions
c6f5175 
update the securitycenter versions in the bom
@chingor13 chingor13 merged commit bb0fc13 into googleapis:master Nov 26, 2019
@chingor13 chingor13 deleted the stop-circular-bom branch November 26, 2019 18:18
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@elharo elharo elharo left review comments

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chingor13 @elharo @BenWhitehead @googlebot