Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Nov 19, 2019

@elharo elharo added the semver: patch A minor bug fix or small change. label Nov 19, 2019
@elharo elharo requested a review from BenWhitehead November 19, 2019 14:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2019
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #6820 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6820      +/-   ##
============================================
+ Coverage     46.37%   46.37%   +<.01%     
- Complexity    28028    28029       +1     
============================================
  Files          2615     2615              
  Lines        288309   288309              
  Branches      33809    33809              
============================================
+ Hits         133709   133712       +3     
+ Misses       144334   144333       -1     
+ Partials      10266    10264       -2
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.12% <0%> (+0.51%) 23% <0%> (ø) ⬇️
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 87% <0%> (+1%) 37% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c109fc...8c80ec9. Read the comment docs.

Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, how about you @chingor13?

@chingor13 chingor13 merged commit 4c166c5 into master Nov 19, 2019
@chingor13 chingor13 deleted the elharo-patch-5 branch November 19, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. semver: patch A minor bug fix or small change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants