Skip to content

add libraries-bom to template #6797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elharo wants to merge 1 commit into from
Closed

add libraries-bom to template #6797

elharo wants to merge 1 commit into from

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Nov 15, 2019

@elharo elharo requested a review from chingor13 November 15, 2019 12:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2019
@codecov
Copy link

codecov bot commented Nov 15, 2019 •
edited
Loading

Codecov Report

Merging #6797 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6797      +/-   ##
============================================
- Coverage     46.06%   46.01%   -0.05%     
+ Complexity    28044    26527    -1517     
============================================
  Files          2615     2615              
  Lines        288309   282905    -5404     
  Branches      33779    33612     -167     
============================================
- Hits         132809   130185    -2624     
+ Misses       144373   143430     -943     
+ Partials      11127     9290    -1837
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java 79.16% <0%> (-2.32%) 26% <0%> (-9%)
...e/cloud/vision/v1p1beta1/ImageAnnotatorClient.java 42.3% <0%> (-2.14%) 6% <0%> (-1%)
...aming/v1alpha/GameServerClustersServiceClient.java 65.93% <0%> (-2.11%) 21% <0%> (-1%)
... and 654 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3d78f...d86ec30. Read the comment docs.

elharo
elharo commented Nov 19, 2019
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping

elharo
elharo commented Nov 25, 2019
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping ping ping

@chingor13
Copy link
Contributor

chingor13 commented Nov 25, 2019 •
edited
Loading

This template is not used anymore with the repo split

@elharo
Copy link
Contributor Author

elharo commented Nov 25, 2019

In that case we should delete it.

@chingor13
Copy link
Contributor

chingor13 commented Nov 25, 2019

Opened #6896 to delete the unnecessary utilities

@chingor13 chingor13 closed this Nov 25, 2019
@chingor13 chingor13 deleted the i6795 branch November 25, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

README.md.tmpl should reference the BOM

3 participants

@elharo @chingor13 @googlebot