Skip to content

BOM 2.9.0 #6793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elharo merged 1 commit into from
Nov 20, 2019
Merged

BOM 2.9.0 #6793

elharo merged 1 commit into from
Nov 20, 2019

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Nov 15, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2019
@elharo elharo requested a review from athakor November 15, 2019 11:49
@codecov
Copy link

codecov bot commented Nov 15, 2019 •
edited
Loading

Codecov Report

Merging #6793 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6793      +/-   ##
============================================
+ Coverage     46.06%   46.37%   +0.31%     
+ Complexity    28044    28028      -16     
============================================
  Files          2615     2615              
  Lines        288309   288309              
  Branches      33779    33809      +30     
============================================
+ Hits         132809   133710     +901     
+ Misses       144373   144334      -39     
+ Partials      11127    10265     -862
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/bigquery/QueryJobConfiguration.java 77.14% <0%> (+0.28%) 56% <0%> (ø) ⬇️
...main/java/com/google/cloud/storage/BucketInfo.java 83.18% <0%> (+0.35%) 84% <0%> (ø) ⬇️
...om/google/cloud/bigquery/LoadJobConfiguration.java 90.15% <0%> (+0.39%) 52% <0%> (ø) ⬇️
...ogle/cloud/bigquery/WriteChannelConfiguration.java 86.12% <0%> (+0.47%) 44% <0%> (ø) ⬇️
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 86% <0%> (+0.5%) 36% <0%> (ø) ⬇️
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 66.78% <0%> (+0.52%) 57% <0%> (ø) ⬇️
...java/com/google/cloud/firestore/FirestoreImpl.java 82.06% <0%> (+0.54%) 23% <0%> (ø) ⬇️
...ud/spanner/jdbc/AbstractJdbcPreparedStatement.java 90.85% <0%> (+0.6%) 52% <0%> (ø) ⬇️
.../com/google/cloud/compute/deprecated/DiskInfo.java 96.5% <0%> (+0.69%) 29% <0%> (ø) ⬇️
...google/cloud/monitoring/v3/GroupServiceClient.java 61.53% <0%> (+0.96%) 26% <0%> (ø) ⬇️
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3d78f...3c26fc8. Read the comment docs.

elharo
elharo commented Nov 19, 2019
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping

elharo
elharo commented Nov 20, 2019
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping

athakor
athakor reviewed Nov 20, 2019
View reviewed changes
@elharo elharo merged commit 191f12e into master Nov 20, 2019
@elharo elharo deleted the elharo-patch-6 branch November 20, 2019 15:53
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@athakor athakor athakor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elharo @athakor @googlebot