Skip to content

Spanner: Fix session leak on allowNestedTransaction #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skuruppu merged 1 commit into from
Nov 18, 2019
Merged

Spanner: Fix session leak on allowNestedTransaction #6791

skuruppu merged 1 commit into from
Nov 18, 2019

Conversation

@olavloite
Copy link

@olavloite olavloite commented Nov 15, 2019 •
edited by skuruppu
Loading

Fixes session leaks when using allowNestedTransactions.

Fixes #6813

@olavloite olavloite added the api: spanner Issues related to the Spanner API. label Nov 15, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2019
@olavloite olavloite force-pushed the spanner-fix-session-leak-nested-tx branch from 8ed7a3a to fe177b7 Compare November 15, 2019 10:36
@codecov
Copy link

codecov bot commented Nov 15, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2f3d78f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6791   +/-   ##
=========================================
  Coverage          ?   46.37%           
  Complexity        ?    28028           
=========================================
  Files             ?     2615           
  Lines             ?   288309           
  Branches          ?    33809           
=========================================
  Hits              ?   133710           
  Misses            ?   144334           
  Partials          ?    10265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3d78f...fe177b7. Read the comment docs.

@olavloite olavloite requested a review from skuruppu November 15, 2019 11:31
@skuruppu skuruppu mentioned this pull request Nov 18, 2019
Closed
skuruppu
skuruppu approved these changes Nov 18, 2019
View reviewed changes
Copy link

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix.

@skuruppu skuruppu merged commit 2c109fc into googleapis:master Nov 18, 2019
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spanner: allowNestedTransaction() of TransactionRunner causes SessionPool$LeakedSessionException

3 participants

@olavloite @skuruppu @googlebot