Skip to content

Bigquery: add Description field for Routine entities. #6761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmakani merged 1 commit into from
Nov 14, 2019
Merged

Bigquery: add Description field for Routine entities. #6761

pmakani merged 1 commit into from
Nov 14, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Nov 13, 2019

Fixes #6753

@pmakani pmakani requested a review from shollyman November 13, 2019 12:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2019
@codecov
Copy link

codecov bot commented Nov 13, 2019 •
edited
Loading

Codecov Report

Merging #6761 into master will increase coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6761      +/-   ##
============================================
+ Coverage     46.37%   46.37%   +<.01%     
- Complexity    28024    28025       +1     
============================================
  Files          2614     2614              
  Lines        288317   288327      +10     
  Branches      33810    33810              
============================================
+ Hits         133715   133721       +6     
- Misses       144336   144340       +4     
  Partials      10266    10266
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/bigquery/Routine.java 79.24% <0%> (-3.11%) 11 <0> (ø)
...in/java/com/google/cloud/bigquery/RoutineInfo.java 67.47% <75%> (+0.52%) 21 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d63be...62bf92f. Read the comment docs.

@pmakani pmakani merged commit 740c755 into googleapis:master Nov 14, 2019
@pmakani pmakani deleted the api-bigquery-6753 branch November 14, 2019 04:46
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

+1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigquery: add Description field for Routine entities

4 participants

@pmakani @shollyman @elharo @googlebot