Skip to content

update http-client to 1.33.0, datastore-v1-proto-client to 1.6.3 #6717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Nov 11, 2019
Merged

update http-client to 1.33.0, datastore-v1-proto-client to 1.6.3 #6717

chingor13 merged 1 commit into from
Nov 11, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Nov 11, 2019

Fixes #6680

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2019
@chingor13 chingor13 mentioned this pull request Nov 11, 2019
Closed
1 task
@chingor13 chingor13 requested a review from a team November 11, 2019 22:08
@chingor13 chingor13 merged commit 4a751bd into googleapis:master Nov 11, 2019
@chingor13 chingor13 deleted the http-datastore branch November 11, 2019 22:27
@codecov
Copy link

codecov bot commented Nov 11, 2019 •
edited
Loading

Codecov Report

Merging #6717 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6717      +/-   ##
============================================
+ Coverage     45.72%   46.09%   +0.36%     
- Complexity    26521    28024    +1503     
============================================
  Files          2614     2614              
  Lines        282774   288180    +5406     
  Branches      32746    32943     +197     
============================================
+ Hits         129297   132827    +3530     
- Misses       143356   144257     +901     
- Partials      10121    11096     +975
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.65% <0%> (-6.81%) 147% <0%> (+36%)
...onitoring/v3/NotificationChannelServiceClient.java 59.17% <0%> (-6.37%) 43% <0%> (+10%)
.../com/google/cloud/compute/v1/TargetPoolClient.java 52.06% <0%> (-6.18%) 47% <0%> (+11%)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-6.16%) 55% <0%> (+13%)
...oogle/cloud/kms/v1/KeyManagementServiceClient.java 57.61% <0%> (-6.11%) 103% <0%> (+25%)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-6.08%) 31% <0%> (+7%)
...a/com/google/cloud/compute/v1/NodeGroupClient.java 54.95% <0%> (-6.08%) 51% <0%> (+12%)
.../com/google/cloud/compute/v1/SubnetworkClient.java 54.95% <0%> (-6.08%) 51% <0%> (+12%)
...com/google/cloud/compute/v1/ReservationClient.java 53.65% <0%> (-6.07%) 39% <0%> (+9%)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-6.03%) 51% <0%> (+12%)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 451938d...515eb2b. Read the comment docs.

@chingor13 chingor13 mentioned this pull request Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http-client + datastore

3 participants

@chingor13 @codyoss @googlebot