Skip to content

Datastore : Reference libraries-bom in docs #6715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elharo merged 2 commits into from
Nov 11, 2019
Merged

Datastore : Reference libraries-bom in docs #6715

elharo merged 2 commits into from
Nov 11, 2019

Conversation

@athakor
Copy link
Contributor

@athakor athakor commented Nov 11, 2019

towards #6668

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2019
@athakor athakor requested review from chingor13 and elharo November 11, 2019 08:44
@codecov
Copy link

codecov bot commented Nov 11, 2019 •
edited
Loading

Codecov Report

Merging #6715 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6715      +/-   ##
============================================
+ Coverage     46.37%   46.37%   +<.01%     
+ Complexity    28040    28026      -14     
============================================
  Files          2614     2614              
  Lines        288317   288317              
  Branches      33805    33810       +5     
============================================
+ Hits         133715   133718       +3     
+ Misses       144336   144334       -2     
+ Partials      10266    10265       -1
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.61% <0%> (-0.52%) 23% <0%> (ø)
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 87% <0%> (+1%) 37% <0%> (+1%) ⬆️
...able/gaxx/reframing/ReframingResponseObserver.java 90.82% <0%> (+1.83%) 30% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5f5fc...2f78997. Read the comment docs.

@elharo elharo merged commit dc3a1a8 into googleapis:master Nov 11, 2019
@chingor13 chingor13 mentioned this pull request Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@athakor @elharo @googlebot