Skip to content

Regenerate spanner client #6714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skuruppu merged 2 commits into from
Nov 12, 2019
Merged

Regenerate spanner client #6714

skuruppu merged 2 commits into from
Nov 12, 2019

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Nov 10, 2019

This PR was generated using Autosynth. 🌈

Log from Synthtool 
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-spanner/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:545c758c76c3f779037aa259023ec3d1ef2d57d2c8cd00a222cb187d63ceac5e
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 190 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 80 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 25 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 32 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2019
yoshi-automation and others added 2 commits November 12, 2019 10:34
@yoshi-automation @skuruppu
Regenerate spanner client
8855761
@skuruppu
Remove incorrect "com.google.iam.v1." prefix.
6c255bd 
synthtool incorrectly generated code with a "com.google.iam.v1." prefix
for DatabaseName and InstanceName.
skuruppu
skuruppu approved these changes Nov 12, 2019
View reviewed changes
Copy link

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but following up with @kolea2 offline on how to fix the underlying issue so that the code generation doesn't include the spurious "com.google.iam.v1." prefix.

@codecov
Copy link

codecov bot commented Nov 12, 2019 •
edited
Loading

Codecov Report

Merging #6714 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #6714     +/-   ##
===========================================
  Coverage     46.37%   46.37%             
- Complexity    26523    28024   +1501     
===========================================
  Files          2614     2614             
  Lines        288317   288317             
  Branches      33805    33810      +5     
===========================================
  Hits         133714   133714             
  Misses       144336   144336             
  Partials      10267    10267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a751bd...6c255bd. Read the comment docs.

@skuruppu skuruppu merged commit 66a3423 into master Nov 12, 2019
@skuruppu skuruppu deleted the autosynth-spanner branch November 12, 2019 01:28
@chingor13 chingor13 mentioned this pull request Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @skuruppu @googlebot