Skip to content

BigQuery: implement scripting support. #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmakani merged 3 commits into from
Nov 7, 2019
Merged

BigQuery: implement scripting support. #6706

pmakani merged 3 commits into from
Nov 7, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Nov 7, 2019

Fixes #6489

@pmakani pmakani requested a review from shollyman November 7, 2019 06:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2019
@codecov
Copy link

codecov bot commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #6706 into master will decrease coverage by <.01%.
The diff coverage is 43.1%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6706      +/-   ##
============================================
- Coverage     46.36%   46.35%   -0.01%     
  Complexity    28018    28018              
============================================
  Files          2614     2614              
  Lines        288194   288308     +114     
  Branches      33795    33805      +10     
============================================
+ Hits         133609   133657      +48     
- Misses       144334   144398      +64     
- Partials      10251    10253       +2
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/google/cloud/bigquery/BigQuery.java 77.15% <0%> (-0.4%) 0 <0> (ø)
.../com/google/cloud/bigquery/spi/v2/BigQueryRpc.java 81.81% <100%> (+0.86%) 0 <0> (ø) ⬇️
.../java/com/google/cloud/bigquery/JobStatistics.java 79.65% <42.98%> (-14.27%) 13 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c2258...a68e870. Read the comment docs.

shollyman
shollyman approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks present, but perhaps some testing of a constructed stackframe since it looks like there's no testing of fields at present?

@shollyman
Copy link
Contributor

shollyman commented Nov 7, 2019

Thanks Praful!

@pmakani pmakani merged commit ba82cfc into googleapis:master Nov 7, 2019
@pmakani pmakani deleted the api-bigquery-6489 branch November 7, 2019 13:30
@chingor13 chingor13 mentioned this pull request Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: implement scripting support

3 participants

@pmakani @shollyman @googlebot