Skip to content

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Oct 30, 2019

No description provided.

@codyoss codyoss requested a review from chingor13 October 30, 2019 19:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2019
</plugins>
</build>

<build>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing with 2 build tags in here

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #6660 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6660      +/-   ##
============================================
- Coverage     46.35%   46.35%   -0.01%     
  Complexity    28005    28005              
============================================
  Files          2613     2613              
  Lines        288087   288087              
  Branches      33783    33783              
============================================
- Hits         133534   133531       -3     
- Misses       144309   144312       +3     
  Partials      10244    10244
Impacted Files Coverage Δ Complexity Δ
.../cloud/datastore/testing/LocalDatastoreHelper.java 80.59% <0%> (-4.48%) 17% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c6f13...1eb6618. Read the comment docs.

@chingor13 chingor13 merged commit e504762 into googleapis:master Oct 30, 2019
@codyoss codyoss deleted the stop-logging branch October 31, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants