Skip to content

Do not merge: testing #6650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chingor13 wants to merge 7 commits into from
Closed

Do not merge: testing #6650

chingor13 wants to merge 7 commits into from

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Oct 29, 2019

This is a combination of #6606 and #6649 to see if it fixes the presubmit

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
@chingor13 chingor13 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 29, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
This was referenced Oct 29, 2019
Merged
Merged
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #6650 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6650      +/-   ##
============================================
- Coverage     46.35%   45.99%   -0.37%     
+ Complexity    28002    26516    -1486     
============================================
  Files          2613     2613              
  Lines        288075   282671    -5404     
  Branches      33779    33577     -202     
============================================
- Hits         133528   130001    -3527     
+ Misses       144308   143405     -903     
+ Partials      10239     9265     -974
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java 79.16% <0%> (-2.32%) 26% <0%> (-9%)
...e/cloud/vision/v1p1beta1/ImageAnnotatorClient.java 42.3% <0%> (-2.14%) 6% <0%> (-1%)
...aming/v1alpha/GameServerClustersServiceClient.java 65.93% <0%> (-2.11%) 21% <0%> (-1%)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa84666...6a1c15a. Read the comment docs.

@chingor13 chingor13 closed this Oct 29, 2019
@chingor13 chingor13 deleted the bom-upper-bounds-dep-update branch October 29, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @googlebot @suztomo