Skip to content

deps: update google-cloud-core to 1.91.3 #6649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Oct 29, 2019
Merged

deps: update google-cloud-core to 1.91.3 #6649

chingor13 merged 1 commit into from
Oct 29, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Oct 29, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
@chingor13 chingor13 mentioned this pull request Oct 29, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 29, 2019 •
edited
Loading

Codecov Report

Merging #6649 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6649      +/-   ##
============================================
- Coverage     46.35%   46.03%   -0.32%     
- Complexity    28002    28017      +15     
============================================
  Files          2613     2613              
  Lines        288075   288075              
  Branches      33779    33749      -30     
============================================
- Hits         133528   132624     -904     
- Misses       144308   144348      +40     
- Partials      10239    11103     +864
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.65% <0%> (-6.45%) 147% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 47.9% <0%> (-5.99%) 43% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.01% <0%> (-5.89%) 39% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-5.69%) 51% <0%> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa84666...aca53e8. Read the comment docs.

@chingor13 chingor13 requested a review from a team October 29, 2019 17:36
@chingor13 chingor13 mentioned this pull request Oct 29, 2019
Merged
@elharo
Copy link
Contributor

elharo commented Oct 29, 2019

@suztomo do you know what happened here?

[09:57:13] Command done in 274 seconds
[09:57:18][ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration bom-upper-bounds under /tmp/workspace/workspace/cloud-devrel/client-libraries/java/google-cloud-java/presubmit/bom-upper-bounds/src/github/google-cloud-java/.kokoro/presubmit.
at com.google.devtools.kokoro.config.BuildConfigReader.lambda$read$2(BuildConfigReader.java:54)
at java.util.Optional.orElseThrow(Optional.java:290)

@chingor13
Copy link
Contributor Author

chingor13 commented Oct 29, 2019 •
edited
Loading

The test job configuration is in the other, unmerged PR which is why I opened #6650 to combine the PRs to test.

@chingor13 chingor13 merged commit 30d73fd into googleapis:master Oct 29, 2019
@chingor13 chingor13 deleted the update-java-core branch October 29, 2019 19:29
@chingor13 chingor13 mentioned this pull request Oct 30, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @elharo @googlebot