Skip to content

chore: stop release of scheduler #6575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 4 commits into from
Oct 30, 2019
Merged

chore: stop release of scheduler #6575

chingor13 merged 4 commits into from
Oct 30, 2019

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Oct 25, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2019
@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #6575 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6575      +/-   ##
============================================
- Coverage     46.34%   46.03%   -0.32%     
- Complexity    28005    28021      +16     
============================================
  Files          2613     2613              
  Lines        288087   288087              
  Branches      33783    33753      -30     
============================================
- Hits         133528   132632     -896     
- Misses       144315   144348      +33     
- Partials      10244    11107     +863
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.65% <0%> (-6.45%) 147% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 47.9% <0%> (-5.99%) 43% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.01% <0%> (-5.89%) 39% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-5.69%) 51% <0%> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f23d93c...161a841. Read the comment docs.

@codyoss codyoss marked this pull request as ready for review October 25, 2019 18:50
@codyoss codyoss requested a review from chingor13 October 25, 2019 18:50
@codyoss
Copy link
Member Author

codyoss commented Oct 28, 2019

Being that no code was actually touched here, I think the cov is fine. Really interesting the build thinks this is a regression...

chingor13
chingor13 requested changes Oct 28, 2019
View reviewed changes
@codyoss codyoss requested a review from chingor13 October 29, 2019 15:19
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2019
@chingor13 chingor13 removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2019
@chingor13 chingor13 merged commit ea46b41 into googleapis:master Oct 30, 2019
@chingor13 chingor13 mentioned this pull request Oct 30, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codyoss @chingor13 @googlebot