Skip to content

Conversation

@pmakani
Copy link

@pmakani pmakani commented Oct 23, 2019

PR Contains :

RangePartitioning classes and properties add support for the integer range
partitioning feature. These offer more flexibility in partitioning options than
time-based partitioning.

@pmakani pmakani requested a review from shollyman October 23, 2019 12:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2019
@pmakani pmakani added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #6552 into master will increase coverage by 0.01%.
The diff coverage is 78.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6552      +/-   ##
============================================
+ Coverage     46.34%   46.36%   +0.01%     
- Complexity    27997    28018      +21     
============================================
  Files          2613     2614       +1     
  Lines        288068   288194     +126     
  Branches      33778    33790      +12     
============================================
+ Hits         133516   133609      +93     
- Misses       144312   144334      +22     
- Partials      10240    10251      +11
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/StandardTableDefinition.java 86.76% <0%> (-5.43%) 14 <0> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 90.15% <100%> (+0.44%) 52 <1> (+2) ⬆️
...m/google/cloud/bigquery/QueryJobConfiguration.java 77.14% <100%> (+0.74%) 56 <1> (+2) ⬆️
...a/com/google/cloud/bigquery/RangePartitioning.java 75% <75%> (ø) 9 <9> (?)
...main/java/com/google/cloud/storage/BucketInfo.java 83.18% <0%> (-1.19%) 84% <0%> (ø)
...rc/main/java/com/google/cloud/firestore/Query.java 91.89% <0%> (-0.8%) 94% <0%> (+4%)
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java 55% <0%> (ø) 35% <0%> (ø) ⬇️
...main/java/com/google/cloud/firestore/Internal.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...com/google/cloud/bigquery/QueryParameterValue.java 72.72% <0%> (+0.35%) 46% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f643b...ccaa9c6. Read the comment docs.

Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The backend is now enabled, so this can be submitted and released.

this.range = Range.fromPb(rangePartitioning.getRange());
}

/** Returns the field of range partitioning. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/** Returns the range partitioning field. */

@pmakani pmakani merged commit 1b9a2a9 into googleapis:master Nov 6, 2019
@pmakani pmakani deleted the api-bigquery-rangepartitioning branch November 6, 2019 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants