Os-Login : Added ITSystem Test #6538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6538 +/- ##
=========================================
Coverage 46.35% 46.35%
Complexity 27998 27998
=========================================
Files 2613 2613
Lines 288068 288068
Branches 33778 33778
=========================================
Hits 133521 133521
Misses 144308 144308
Partials 10239 10239
Continue to review full report at Codecov.
|
chingor13
requested changes
Oct 22, 2019
Comment on lines
56
to
57
| user = getFromCredential(GOOGLE_API_CLIENT_EMAIL_ID); | ||
| clientId = getFromCredential(GOOGLE_API_CLIENT_ID); |
Contributor
There was a problem hiding this comment.
nit: These could be done in a static @BeforeAll setup block so we only have to read them once.
| private static final String GOOGLE_API_CLIENT_EMAIL_ID = "clientEmail"; | ||
| private static final String GOOGLE_API_CLOUD_PLATFORM_LINK = | ||
| "https://www.googleapis.com/auth/cloud-platform"; | ||
| private static final String FINGERPRINT_NAME = "test-fingerprint"; |
Contributor
There was a problem hiding this comment.
For clarity, let's name this NON_EXISTENT_FINGERPRINT_NAME to make it clear that we expect this one to not exist.
Contributor
Author
|
@chingor13 PTAL |
chingor13
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #5946