Skip to content

spanner: Increase PDML test timeout #6529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skuruppu merged 1 commit into from
Oct 22, 2019
Merged

spanner: Increase PDML test timeout #6529

skuruppu merged 1 commit into from
Oct 22, 2019

Conversation

@olavloite
Copy link

@olavloite olavloite commented Oct 18, 2019

Increase the test timeout for PDML as setting a too short timeout can cause a NullPointerException when using a gRPC LocalChannelProvider. This seems to be caused by the problem reported in grpc/grpc-java#6300.

This fixes the build error in #6528

@olavloite
spanner: Increase PDML test timeout
1748b20 
Increase the test timeout for PDML as setting a too short
timeout can cause a NullPointerException when using a gRPC
LocalChannelProvider. This seems to be caused by the problem
reported in grpc/grpc-java#6300.
@olavloite olavloite requested a review from skuruppu October 18, 2019 14:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2019
@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #6529 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6529      +/-   ##
============================================
+ Coverage     46.06%   46.35%   +0.28%     
  Complexity    27995    27995              
============================================
  Files          2613     2613              
  Lines        287931   288066     +135     
  Branches      32909    33776     +867     
============================================
+ Hits         132637   133524     +887     
- Misses       144225   144303      +78     
+ Partials      11069    10239     -830
Impacted Files Coverage Δ Complexity Δ
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...le/cloud/storage/contrib/nio/CloudStoragePath.java 75.67% <0%> (-0.69%) 51% <0%> (ø)
...ge/contrib/nio/CloudStorageFileSystemProvider.java 62.76% <0%> (-0.3%) 73% <0%> (ø)
...ain/java/com/google/cloud/logging/LoggingImpl.java 87.9% <0%> (-0.19%) 73% <0%> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 76.72% <0%> (-0.16%) 108% <0%> (ø)
...m/google/cloud/spanner/jdbc/JdbcTypeConverter.java 74.86% <0%> (-0.14%) 88% <0%> (ø)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 87.67% <0%> (-0.13%) 165% <0%> (ø)
...src/main/java/io/grafeas/v1/UpdateNoteRequest.java 11.74% <0%> (-0.08%) 11% <0%> (ø)
...in/java/io/grafeas/v1/UpdateOccurrenceRequest.java 11.71% <0%> (-0.08%) 11% <0%> (ø)
...ava/io/grafeas/v1/ListNoteOccurrencesResponse.java 14.28% <0%> (-0.05%) 10% <0%> (ø)
... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6992e...1748b20. Read the comment docs.

@skuruppu skuruppu merged commit 8805c37 into googleapis:master Oct 22, 2019
@olavloite olavloite deleted the spanner-inc-test-timeout branch October 22, 2019 09:02
@chingor13 chingor13 mentioned this pull request Oct 30, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite @skuruppu @googlebot