spanner-jdbc: GCS dependency should be scope provided #6528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Google Cloud Storage dependency is only used for loading credentials from storage if a user specifies a GCS URL. Adding the entire GCS client library as a dependency only for this feature is not very user friendly. Instead the dependency should be scope provided, and users wanting to use this feature should add a GCS dependency explicitly. Fixes googleapis#6474.
googlebot
added
the
cla: yes
skuruppu
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Cloud Storage dependency is only used for loading credentials from storage if a user specifies a GCS URL. Adding the entire GCS client library as a dependency only for this feature is not very user friendly. Instead the dependency should be scope provided, and users wanting to
use this feature should add a GCS dependency explicitly.
Fixes #6474.