Skip to content

Bigquery: Fix bug QueryParameterValue.timestamp(long) conversion causes loss of microsecond precision. #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmakani merged 1 commit into from
Nov 6, 2019
Merged

Bigquery: Fix bug QueryParameterValue.timestamp(long) conversion causes loss of microsecond precision. #6521

pmakani merged 1 commit into from
Nov 6, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Oct 17, 2019

Fixes #6495

@pmakani pmakani requested a review from shollyman October 17, 2019 12:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2019
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2019
@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited
Loading

Codecov Report

Merging #6521 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6521      +/-   ##
============================================
+ Coverage     46.35%   46.35%   +<.01%     
  Complexity    27995    27995              
============================================
  Files          2613     2613              
  Lines        288066   288068       +2     
  Branches      33776    33776              
============================================
+ Hits         133524   133526       +2     
  Misses       144303   144303              
  Partials      10239    10239
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/bigquery/QueryParameterValue.java 72.72% <100%> (+0.35%) 46 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b61b8...ab8fb28. Read the comment docs.

shollyman
shollyman approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmakani pmakani merged commit 1fcf0e5 into googleapis:master Nov 6, 2019
@pmakani pmakani deleted the api-bigquery-6495 branch November 6, 2019 04:17
This was referenced Nov 6, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: QueryParameterValue.timestamp(long) conversion causes loss of microsecond precision

5 participants

@pmakani @shollyman @googlebot @yoshi-kokoro @athakor