Skip to content

Prepare webrisk client for extraction #6513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 2 commits into from
Oct 16, 2019
Merged

Prepare webrisk client for extraction #6513

chingor13 merged 2 commits into from
Oct 16, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Oct 15, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2019
kolea2
kolea2 approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

@codecov
Copy link

codecov bot commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #6513 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6513      +/-   ##
============================================
+ Coverage     45.99%   46.35%   +0.36%     
- Complexity    26494    27995    +1501     
============================================
  Files          2613     2613              
  Lines        282662   288066    +5404     
  Branches      33579    33776     +197     
============================================
+ Hits         129999   133524    +3525     
- Misses       143399   144303     +904     
- Partials       9264    10239     +975
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 55.09% <0%> (-7.79%) 147% <0%> (+36%)
...onitoring/v3/NotificationChannelServiceClient.java 64.49% <0%> (-7.13%) 43% <0%> (+10%)
...ava/com/google/cloud/compute/v1/ProjectClient.java 57.07% <0%> (-6.99%) 55% <0%> (+13%)
.../com/google/cloud/compute/v1/TargetPoolClient.java 57.73% <0%> (-6.98%) 47% <0%> (+11%)
...va/com/google/cloud/compute/v1/SnapshotClient.java 55.73% <0%> (-6.88%) 31% <0%> (+7%)
...oogle/cloud/kms/v1/KeyManagementServiceClient.java 62.88% <0%> (-6.84%) 103% <0%> (+25%)
...com/google/cloud/compute/v1/ReservationClient.java 59.14% <0%> (-6.83%) 39% <0%> (+9%)
...a/com/google/cloud/compute/v1/NodeGroupClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
.../com/google/cloud/compute/v1/SubnetworkClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
...d/compute/v1/RegionInstanceGroupManagerClient.java 54.5% <0%> (-6.79%) 51% <0%> (+12%)
... and 639 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e5cb0...e411856. Read the comment docs.

@chingor13 chingor13 merged commit 10b61b8 into googleapis:master Oct 16, 2019
@chingor13 chingor13 deleted the extract-webrisk branch October 16, 2019 19:32
@chingor13 chingor13 mentioned this pull request Oct 16, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @kolea2 @googlebot