Skip to content

Prepare datacatalog client for extraction #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 3 commits into from
Oct 15, 2019
Merged

Prepare datacatalog client for extraction #6486

chingor13 merged 3 commits into from
Oct 15, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Oct 10, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2019
@codecov
Copy link

codecov bot commented Oct 10, 2019 •
edited
Loading

Codecov Report

Merging #6486 into master will increase coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6486      +/-   ##
============================================
+ Coverage     45.69%   46.35%   +0.65%     
- Complexity    26492    27996    +1504     
============================================
  Files          2613     2613              
  Lines        282525   288066    +5541     
  Branches      32712    33776    +1064     
============================================
+ Hits         129104   133526    +4422     
- Misses       143327   144302     +975     
- Partials      10094    10238     +144
Impacted Files Coverage Δ Complexity Δ
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...va/com/google/cloud/tasks/v2/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...m/google/cloud/tasks/v2beta2/CloudTasksClient.java 57.14% <0%> (-2.39%) 79% <0%> (+19%)
...oogle/cloud/firestore/v1/FirestoreAdminClient.java 59.84% <0%> (-2.23%) 38% <0%> (+8%)
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
...oogle/cloud/scheduler/v1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
...google/cloud/monitoring/v3/GroupServiceClient.java 61.53% <0%> (-2.01%) 26% <0%> (+5%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 89.58% <0%> (-1.91%) 32% <0%> (ø)
...eas/src/main/java/io/grafeas/v1/GrafeasClient.java 61.63% <0%> (-1.47%) 59% <0%> (+14%)
... and 665 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 513a261...694d9f0. Read the comment docs.

@chingor13 chingor13 requested a review from a team October 14, 2019 22:23
@chingor13 chingor13 merged commit 6ffcd7b into googleapis:master Oct 15, 2019
@chingor13 chingor13 deleted the extract-datacatalog branch October 15, 2019 19:18
@chingor13 chingor13 mentioned this pull request Oct 16, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @codyoss @googlebot