Declare direct dependencies in google-cloud-bigtable pom.xml #6484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
igorbernstein2
left a comment
igorbernstein2
left a comment
There was a problem hiding this comment.
Thanks for digging into this! This looks great, but I think can be a improved a bit
...igtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsRetryTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6484 +/- ##
============================================
+ Coverage 46.34% 46.34% +<.01%
- Complexity 27974 28009 +35
============================================
Files 2613 2613
Lines 287955 288056 +101
Branches 33756 33769 +13
============================================
+ Hits 133456 133512 +56
- Misses 144279 144306 +27
- Partials 10220 10238 +18
Continue to review full report at Codecov.
|
igorbernstein2
left a comment
igorbernstein2
left a comment
There was a problem hiding this comment.
This looks great, except for a few nits. Other then couple of inline comments, can you also run a diff of mvn dependency:list of the old Pom and the new? And post it in the description of the pr for future reference?
justinuang
commented
Oct 14, 2019
Author
justinuang
left a comment
justinuang
left a comment
There was a problem hiding this comment.
justinuang@justinuang1:~/code/google-cloud-java$ diff -U -1 {old,new}_dependencies.txt
--- old_dependencies.txt 2019-10-14 17:21:25.522738087 -0400
+++ new_dependencies.txt 2019-10-14 17:21:13.846827193 -0400
@@ -1,66 +1,66 @@
The following files have been resolved:
com.fasterxml.jackson.core:jackson-core:jar:2.9.9:compile
com.google.android:annotations:jar:4.1.1.4:compile
com.google.api.grpc:grpc-google-cloud-bigtable-admin-v2:jar:0.79.0:test
com.google.api.grpc:grpc-google-cloud-bigtable-v2:jar:0.79.0:test
com.google.api.grpc:proto-google-cloud-bigtable-admin-v2:jar:0.79.0:compile
com.google.api.grpc:proto-google-cloud-bigtable-v2:jar:0.79.0:compile
com.google.api.grpc:proto-google-cloud-firestore-v1:jar:1.26.0:test
com.google.api.grpc:proto-google-common-protos:jar:1.16.0:compile
com.google.api.grpc:proto-google-iam-v1:jar:0.13.0:compile
com.google.api:api-common:jar:1.8.1:compile
com.google.api:gax-grpc:jar:1.49.0:compile
com.google.api:gax-grpc:jar:testlib:1.49.0:test
com.google.api:gax:jar:1.49.0:compile
com.google.api:gax:jar:testlib:1.49.0:test
com.google.auth:google-auth-library-credentials:jar:0.17.2:compile
com.google.auth:google-auth-library-oauth2-http:jar:0.17.2:compile
com.google.auto.value:auto-value-annotations:jar:1.6.6:compile
com.google.auto.value:auto-value:jar:1.6.6:provided
com.google.cloud:google-cloud-bigtable-emulator:jar:0.114.0-alpha:test
com.google.cloud:google-cloud-conformance-tests:jar:0.1.0-SNAPSHOT:test
com.google.cloud:google-cloud-core-grpc:jar:1.90.0:compile
com.google.cloud:google-cloud-core:jar:1.90.0:compile
com.google.code.findbugs:jsr305:jar:3.0.2:compile
com.google.code.gson:gson:jar:2.8.5:compile
com.google.errorprone:error_prone_annotations:jar:2.3.3:compile
com.google.guava:failureaccess:jar:1.0.1:compile
com.google.guava:guava:jar:28.1-android:compile
com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
com.google.http-client:google-http-client-jackson2:jar:1.32.1:compile
com.google.http-client:google-http-client:jar:1.32.1:compile
com.google.j2objc:j2objc-annotations:jar:1.3:compile
com.google.protobuf:protobuf-java-util:jar:3.10.0:compile
com.google.protobuf:protobuf-java:jar:3.10.0:compile
com.google.truth:truth:jar:1.0:test
com.googlecode.java-diff-utils:diffutils:jar:1.3.0:test
commons-codec:commons-codec:jar:1.11:compile
commons-logging:commons-logging:jar:1.2:compile
- io.grpc:grpc-alts:jar:1.24.0:compile
+ io.grpc:grpc-alts:jar:1.24.0:runtime
io.grpc:grpc-api:jar:1.24.0:compile
io.grpc:grpc-auth:jar:1.24.0:compile
io.grpc:grpc-context:jar:1.24.0:compile
io.grpc:grpc-core:jar:1.24.0:compile
- io.grpc:grpc-grpclb:jar:1.24.0:compile
+ io.grpc:grpc-grpclb:jar:1.24.0:runtime
io.grpc:grpc-netty-shaded:jar:1.24.0:compile
io.grpc:grpc-protobuf-lite:jar:1.24.0:compile
io.grpc:grpc-protobuf:jar:1.24.0:compile
- io.grpc:grpc-stub:jar:1.24.0:compile
+ io.grpc:grpc-stub:jar:1.24.0:test
io.grpc:grpc-testing:jar:1.24.0:test
io.opencensus:opencensus-api:jar:0.24.0:compile
io.opencensus:opencensus-contrib-grpc-metrics:jar:0.21.0:compile
io.opencensus:opencensus-contrib-http-util:jar:0.24.0:compile
io.perfmark:perfmark-api:jar:0.17.0:compile
javax.annotation:javax.annotation-api:jar:1.3.2:compile
junit:junit:jar:4.12:test
- org.apache.commons:commons-lang3:jar:3.5:compile
+ org.apache.commons:commons-lang3:jar:3.5:runtime
org.apache.httpcomponents:httpclient:jar:4.5.10:compile
org.apache.httpcomponents:httpcore:jar:4.4.12:compile
org.checkerframework:checker-compat-qual:jar:2.5.5:compile
org.codehaus.mojo:animal-sniffer-annotations:jar:1.18:compile
org.hamcrest:hamcrest-core:jar:2.1:test
org.hamcrest:hamcrest:jar:2.1:test
org.mockito:mockito-all:jar:1.10.19:test
org.threeten:threetenbp:jar:1.3.3:compile
kolea2
approved these changes
Oct 15, 2019
Contributor
|
Thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
auto-value-annotations should be a compile time dependency: https://github.com/google/auto/blob/master/value/userguide/index.md#in-pomxml
BaseBigtableInstanceAdminSettingsuses iam protosRemove dependency on com.google.http-client:google-http-client because of a wrong import of
ListsWe have to specify the version of threetenbp = 1.3.3 to match gax, as enforced by the dependency convergence rule.
jsr305 is used to provide javax.annotations.Nonnull, etc. These are added to java in java 8, but since we need to be compatible with java 7, we have an explicit import.
@igorbernstein2