Bigtable: Add integration test for DirectPath fallback to and from CFE #6460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
igorbernstein2
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6460 +/- ##
============================================
+ Coverage 45.98% 46.34% +0.35%
- Complexity 26480 27989 +1509
============================================
Files 2613 2613
Lines 282539 288013 +5474
Branches 33559 33770 +211
============================================
+ Hits 129926 133478 +3552
- Misses 143357 144297 +940
- Partials 9256 10238 +982
Continue to review full report at Codecov.
|
Author
|
A bit odd that coverage went down from adding a test 🤷♂️ |
elharo
reviewed
Oct 14, 2019
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Show resolved
Hide resolved
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Show resolved
Hide resolved
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Outdated
Show resolved
Hide resolved
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Outdated
Show resolved
Hide resolved
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Outdated
Show resolved
Hide resolved
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Show resolved
Hide resolved
...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/DirectPathEnv.java
Outdated
Show resolved
Hide resolved
igorbernstein2
commented
Oct 14, 2019
Author
igorbernstein2
left a comment
igorbernstein2
left a comment
There was a problem hiding this comment.
All comments should be addressed, PTAL
Author
|
All comments should be addressed, PTAL |
kolea2
reviewed
Oct 14, 2019
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Show resolved
Hide resolved
igorbernstein2
commented
Oct 15, 2019
Author
igorbernstein2
left a comment
igorbernstein2
left a comment
There was a problem hiding this comment.
All comments should be addressed
kolea2
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//cc @WeiranFang
This test will simulate an IPv6 outage using a faulty Netty ChannelHandler. Unfortunately this requires a reflection hack to extract the underlying NettyChannelBuilder from the ComputeEngine, which makes this test dependent on the implementation of ForwardingChannelBuilder which is marked ExperimentalApi. This isn't great, but it's better than not testing this functionality or doing some kind of man in the middle proxy or trying to implement the grpclb and dns protocols in the test.