Bigquery: Fix defaultPartitionExpirationMs for Dataset. #6445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
elharo
reviewed
Oct 7, 2019
| EncryptionConfiguration defaultEncryptionConfiguration); | ||
|
|
||
| /** | ||
| * [Optional] The default partition expiration for all partitioned tables in the dataset, in |
| /** | ||
| * [Optional] The default partition expiration for all partitioned tables in the dataset, in | ||
| * milliseconds. Once this property is set, all newly-created partitioned tables in the dataset | ||
| * will have an expirationMs property in the timePartitioning settings set to this value, and |
Contributor
There was a problem hiding this comment.
value, and changing --> value. Changing
| * [Optional] The default partition expiration for all partitioned tables in the dataset, in | ||
| * milliseconds. Once this property is set, all newly-created partitioned tables in the dataset | ||
| * will have an expirationMs property in the timePartitioning settings set to this value, and | ||
| * changing the value will only affect new tables, not existing ones. The storage in a partition |
Contributor
There was a problem hiding this comment.
will only --> only
(Tech writing lives in the eternal present)
| * milliseconds. Once this property is set, all newly-created partitioned tables in the dataset | ||
| * will have an expirationMs property in the timePartitioning settings set to this value, and | ||
| * changing the value will only affect new tables, not existing ones. The storage in a partition | ||
| * will have an expiration time of its partition time plus this value. Setting this property |
elharo
added
semver: minor
Codecov Report
@@ Coverage Diff @@
## master #6445 +/- ##
============================================
+ Coverage 46.34% 46.34% +<.01%
- Complexity 27968 27970 +2
============================================
Files 2613 2613
Lines 287931 287942 +11
Branches 33756 33757 +1
============================================
+ Hits 133452 133458 +6
- Misses 144259 144264 +5
Partials 10220 10220
Continue to review full report at Codecov.
|
Author
|
@shollyman PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.