Skip to content

Recommend linkage checker enforcer rule instead of dependency convergence #6399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 3 commits into from
Oct 2, 2019
Merged

Recommend linkage checker enforcer rule instead of dependency convergence #6399

chingor13 merged 3 commits into from
Oct 2, 2019

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Oct 1, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2019
@saturnism
Copy link

saturnism commented Oct 2, 2019

hiya! it looks like the changes are cleaning up the verbiages. where does it recommend linkage checker? thanks!

@elharo
Copy link
Contributor Author

elharo commented Oct 2, 2019

Damn it, looks like I may have put those changes in the wrong client. Let me find them.

elharo
elharo commented Oct 2, 2019
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@codecov
Copy link

codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #6399 into master will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6399      +/-   ##
============================================
+ Coverage     45.93%   46.34%   +0.41%     
- Complexity    26435    27982    +1547     
============================================
  Files          2613     2613              
  Lines        282249   287923    +5674     
  Branches      33537    33750     +213     
============================================
+ Hits         129655   133442    +3787     
- Misses       143350   144262     +912     
- Partials       9244    10219     +975
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 55.09% <0%> (-7.79%) 147% <0%> (+36%)
...onitoring/v3/NotificationChannelServiceClient.java 64.49% <0%> (-7.13%) 43% <0%> (+10%)
...ava/com/google/cloud/compute/v1/ProjectClient.java 57.07% <0%> (-6.99%) 55% <0%> (+13%)
.../com/google/cloud/compute/v1/TargetPoolClient.java 57.73% <0%> (-6.98%) 47% <0%> (+11%)
...va/com/google/cloud/compute/v1/SnapshotClient.java 55.73% <0%> (-6.88%) 31% <0%> (+7%)
...oogle/cloud/kms/v1/KeyManagementServiceClient.java 62.88% <0%> (-6.84%) 103% <0%> (+25%)
...com/google/cloud/compute/v1/ReservationClient.java 59.14% <0%> (-6.83%) 39% <0%> (+9%)
...a/com/google/cloud/compute/v1/NodeGroupClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
.../com/google/cloud/compute/v1/SubnetworkClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
...d/compute/v1/RegionInstanceGroupManagerClient.java 54.5% <0%> (-6.79%) 51% <0%> (+12%)
... and 647 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e692d...3d855c5. Read the comment docs.

@chingor13 chingor13 merged commit cf01a46 into master Oct 2, 2019
@chingor13 chingor13 deleted the trouble branch October 2, 2019 19:33
@chingor13 chingor13 mentioned this pull request Oct 2, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

@saturnism saturnism Awaiting requested review from saturnism

@kolea2 kolea2 Awaiting requested review from kolea2

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elharo @saturnism @chingor13 @googlebot