Skip to content

fix: bump grpc-google-iam to 0.13.0 to introduce GetPolicyOptions #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankyn merged 1 commit into from
Oct 1, 2019
Merged

fix: bump grpc-google-iam to 0.13.0 to introduce GetPolicyOptions #6379

frankyn merged 1 commit into from
Oct 1, 2019

Conversation

@jkwlui
Copy link
Member

@jkwlui jkwlui commented Sep 30, 2019 •
edited
Loading

This is blocking new regeneration of libraries with updated IAM methods.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2019
@jkwlui jkwlui mentioned this pull request Sep 30, 2019
Closed
vam-google
vam-google approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please clarify (in PR description and commit message) what exactly this fix "fixes" (it only bumps the dependency version, but it seems like old one worked just fine for google-cloud-java).

@jkwlui jkwlui changed the title fix: bump grpc-google-iam to 0.13.0 fix: bump grpc-google-iam to 0.13.0 to introduce GetPolicyOptions Sep 30, 2019
@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #6379 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6379      +/-   ##
============================================
+ Coverage     45.93%   46.29%   +0.36%     
- Complexity    26434    27921    +1487     
============================================
  Files          2613     2613              
  Lines        282249   287626    +5377     
  Branches      33537    33735     +198     
============================================
+ Hits         129653   133167    +3514     
- Misses       143351   144253     +902     
- Partials       9245    10206     +961
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 55.09% <0%> (-7.79%) 147% <0%> (+36%)
...onitoring/v3/NotificationChannelServiceClient.java 64.49% <0%> (-7.13%) 43% <0%> (+10%)
...ava/com/google/cloud/compute/v1/ProjectClient.java 57.07% <0%> (-6.99%) 55% <0%> (+13%)
.../com/google/cloud/compute/v1/TargetPoolClient.java 57.73% <0%> (-6.98%) 47% <0%> (+11%)
...va/com/google/cloud/compute/v1/SnapshotClient.java 55.73% <0%> (-6.88%) 31% <0%> (+7%)
...oogle/cloud/kms/v1/KeyManagementServiceClient.java 62.88% <0%> (-6.84%) 103% <0%> (+25%)
...com/google/cloud/compute/v1/ReservationClient.java 59.14% <0%> (-6.83%) 39% <0%> (+9%)
...a/com/google/cloud/compute/v1/NodeGroupClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
.../com/google/cloud/compute/v1/SubnetworkClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
...d/compute/v1/RegionInstanceGroupManagerClient.java 54.5% <0%> (-6.79%) 51% <0%> (+12%)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797f6e0...361a59d. Read the comment docs.

@elharo
Copy link
Contributor

elharo commented Oct 1, 2019

Is this ready to merge?

@frankyn frankyn merged commit 96e692d into googleapis:master Oct 1, 2019
@chingor13 chingor13 mentioned this pull request Oct 2, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@frankyn frankyn frankyn approved these changes

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jkwlui @elharo @frankyn @vam-google @googlebot