Cleaning up the deprecated APIs from Bigtable #6309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains below changes: - Removed deprecated `BulkMutationBatcher.java` from BigtableDataClient and other reference. As `newBulkMutationBatcher(tableId)` is stable. - Removed deprecated `EnhancedBigtableStub#bulkMutateRowsBatchingCallable`. - Renamed V2 from new `MutateRowsBatchingDescriptorV2.java`. - Removed unnecessary qualification from `MutateRowsBatchingDescriptor` javadoc.
googlebot
added
the
cla: yes
Also, removing V2 suffix from the MeasureMutateRowsCallableV2. Updated test case to adapt with latest class.
kolea2
reviewed
Sep 20, 2019
Contributor
kolea2
left a comment
kolea2
left a comment
There was a problem hiding this comment.
Overall LGTM, will let @igorbernstein2 take a look as well. Thanks!
|
|
||
| /** | ||
| * For internal use only. | ||
| * This callable will instrument MutateRows invocations using Opencensus stats. |
Codecov Report
@@ Coverage Diff @@
## master #6309 +/- ##
============================================
- Coverage 46.86% 46.85% -0.02%
+ Complexity 28150 28133 -17
============================================
Files 2604 2601 -3
Lines 287371 287245 -126
Branches 33367 33352 -15
============================================
- Hits 134688 134585 -103
+ Misses 142450 142426 -24
- Partials 10233 10234 +1
Continue to review full report at Codecov.
|
igorbernstein2
approved these changes
Sep 23, 2019
igorbernstein2
left a comment
igorbernstein2
left a comment
There was a problem hiding this comment.
LGTM! Thanks for putting this together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains below changes:
Removed deprecated
BulkMutationBatcher.javafrom BigtableDataClient and other reference. AsnewBulkMutationBatcher(tableId)is stable.Removed deprecated
EnhancedBigtableStub#bulkMutateRowsBatchingCallable.Removing deprecated
MeasureMutateRowsCallable.javaand renamedMeasureMutateRowsCallableV2to match with this.Renamed V2 from new
MutateRowsBatchingDescriptorV2.java.Removed unnecessary qualification from
MutateRowsBatchingDescriptorjavadoc.cc: @kolea2 @igorbernstein2