Skip to content

Bigquery: Expose CMEK functionality for ML models. #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmakani merged 2 commits into from
Sep 24, 2019
Merged

Bigquery: Expose CMEK functionality for ML models. #6303

pmakani merged 2 commits into from
Sep 24, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Sep 19, 2019

Fixes #6300

@pmakani pmakani requested a review from shollyman September 19, 2019 10:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019 •
edited
Loading

Codecov Report

Merging #6303 into master will decrease coverage by <.01%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6303      +/-   ##
============================================
- Coverage     46.87%   46.87%   -0.01%     
- Complexity    28150    28167      +17     
============================================
  Files          2604     2604              
  Lines        287357   287384      +27     
  Branches      33362    33364       +2     
============================================
+ Hits         134692   134698       +6     
- Misses       142448   142453       +5     
- Partials      10217    10233      +16
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Model.java 64.91% <0%> (-2.37%) 12 <0> (ø)
...main/java/com/google/cloud/bigquery/ModelInfo.java 76.66% <90.9%> (+1.12%) 23 <1> (+2) ⬆️
...src/main/java/com/google/cloud/bigquery/JobId.java 81.81% <0%> (-12.92%) 10% <0%> (ø)
...c/main/java/com/google/cloud/bigquery/TableId.java 84% <0%> (-7.67%) 14% <0%> (ø)
...c/main/java/com/google/cloud/bigquery/ModelId.java 72% <0%> (-7.17%) 13% <0%> (ø)
...main/java/com/google/cloud/bigquery/RoutineId.java 70.37% <0%> (-6.56%) 13% <0%> (ø)
...main/java/com/google/cloud/bigquery/DatasetId.java 81.25% <0%> (-5.42%) 13% <0%> (ø)
...google/cloud/bigquery/ExtractJobConfiguration.java 93.18% <0%> (-3.29%) 23% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Field.java 85.39% <0%> (-1.97%) 24% <0%> (ø)
.../java/com/google/cloud/bigquery/FormatOptions.java 44.44% <0%> (-1.71%) 12% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6046bd...61ef46a. Read the comment docs.

shollyman
shollyman reviewed Sep 22, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add some minimal testing e.g. ModelInfoTest to ensure we propagate through builders, etc.

@pmakani
Copy link
Author

pmakani commented Sep 23, 2019

Thanks! Please add some minimal testing e.g. ModelInfoTest to ensure we propagate through builders, etc.

Done, PTAL.

@pmakani pmakani merged commit 6ba66e6 into googleapis:master Sep 24, 2019
@pmakani pmakani deleted the api-bigquery-6300 branch September 24, 2019 04:39
@kolea2 kolea2 mentioned this pull request Sep 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: expose CMEK functionality for ML models

3 participants

@pmakani @shollyman @googlebot