Skip to content

Bigquery: Fix bug when empty or null String for TableId, DatasetId, ModelId and more. #6284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmakani merged 2 commits into from
Sep 20, 2019
Merged

Bigquery: Fix bug when empty or null String for TableId, DatasetId, ModelId and more. #6284

pmakani merged 2 commits into from
Sep 20, 2019

Conversation

@pmakani
Copy link

@pmakani pmakani commented Sep 17, 2019

Fixes #6277

@pmakani pmakani requested a review from shollyman September 17, 2019 13:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2019
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2019
shollyman
shollyman approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@pmakani pmakani merged commit 28466a2 into googleapis:master Sep 20, 2019
@pmakani pmakani deleted the api-bigquery-6277 branch September 20, 2019 04:40
@kolea2 kolea2 mentioned this pull request Sep 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: BigQuery.getTable(TableId) throws NullPointerException when TableId contains an empty table name.

5 participants

@pmakani @shollyman @googlebot @yoshi-kokoro @athakor