Spanner: TransactionRunner should use prepared transaction #6275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Spanner transaction runner that was given a session with a prepared read/write transaction would not use that transaction, but instead always start a new one, causing an extra unnecessary round-trip to the server. This regression was introduced by commit d305770 (PR googleapis#5433).
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6275 +/- ##
============================================
+ Coverage 47.11% 47.11% +<.01%
- Complexity 27378 27379 +1
============================================
Files 2524 2524
Lines 277617 277617
Branches 31984 31984
============================================
+ Hits 130786 130788 +2
+ Misses 137056 137055 -1
+ Partials 9775 9774 -1
Continue to review full report at Codecov.
|
skuruppu
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Spanner transaction runner that was given a session with a prepared read/write transaction would not use that transaction, but instead always start a new one, causing an extra unnecessary round-trip to the
server. This regression was introduced by commit d305770 (PR #5433).