Skip to content

fix logging.properties instructions #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 1 commit into from
Sep 17, 2019
Merged

fix logging.properties instructions #6274

kolea2 merged 1 commit into from
Sep 17, 2019

Conversation

@jeanbza
Copy link

@jeanbza jeanbza commented Sep 14, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2019
@codecov
Copy link

codecov bot commented Sep 14, 2019 •
edited
Loading

Codecov Report

Merging #6274 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6274      +/-   ##
============================================
- Coverage     47.11%   46.74%   -0.37%     
+ Complexity    27378    25908    -1470     
============================================
  Files          2524     2524              
  Lines        277617   272303    -5314     
  Branches      31984    31786     -198     
============================================
- Hits         130786   127296    -3490     
+ Misses       137056   136181     -875     
+ Partials       9775     8826     -949
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java 79.16% <0%> (-2.32%) 26% <0%> (-9%)
...e/cloud/vision/v1p1beta1/ImageAnnotatorClient.java 42.3% <0%> (-2.14%) 6% <0%> (-1%)
...aming/v1alpha/GameServerClustersServiceClient.java 65.93% <0%> (-2.11%) 21% <0%> (-1%)
... and 630 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f1d17...a3d1984. Read the comment docs.

@jeanbza
Copy link
Author

jeanbza commented Sep 17, 2019

(would you mind submitting? I'm unable to)

@kolea2
Copy link
Contributor

kolea2 commented Sep 17, 2019

Sorry, will do!

@kolea2 kolea2 merged commit 812019b into googleapis:master Sep 17, 2019
@chingor13 chingor13 mentioned this pull request Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeanbza @kolea2 @googlebot